Add a clear error when fixture is not defined (closes #2913) (#3108)

DevExpress · Nov 13, 2018 · 26aee9f · 26aee9f
1 parent 591ed4c
commit 26aee9f
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 3 deletions.
diff --git a/src/api/structure/test.js b/src/api/structure/test.js
@@ -13,17 +13,19 @@ export default class Test extends TestingUnit {
         this.fn           = null;
         this.beforeFn     = null;
         this.afterFn      = null;
-        this.requestHooks = this.fixture.requestHooks.length ? Array.from(this.fixture.requestHooks) : [];
+        this.requestHooks = [];
 
         return this.apiOrigin;
     }
 
     _add (name, fn) {
         assertType(is.string, 'apiOrigin', 'The test name', name);
         assertType(is.function, 'apiOrigin', 'The test body', fn);
+        assertType(is.nonNullObject, 'apiOrigin', `The fixture of '${name}' test`, this.fixture);
 
-        this.name = name;
-        this.fn   = wrapTestFunction(fn);
+        this.name         = name;
+        this.fn           = wrapTestFunction(fn);
+        this.requestHooks = union(this.requestHooks, Array.from(this.fixture.requestHooks));
 
         if (this.testFile.collectedTests.indexOf(this) < 0)
             this.testFile.collectedTests.push(this);

diff --git a/test/server/api-test.js b/test/server/api-test.js
@@ -482,6 +482,29 @@ describe('API', function () {
                     });
                 });
         });
+
+        it('Should raise an error if fixture is missing', function () {
+            const file = resolve('test/server/data/test-suites/fixture-is-missing/testfile.js');
+
+            return compile(file)
+                .then(function () {
+                    throw new Error('Promise rejection expected');
+                })
+                .catch(function (err) {
+                    assertAPIError(err, {
+                        stackTop: file,
+
+                        message: 'Cannot prepare tests due to an error.\n\n' +
+                                 'The fixture of \'Test\' test is expected to be a non-null object, but it was null.',
+
+                        callsite: '   1 |// fixture `Fixture`\n' +
+                                  '   2 |\n' +
+                                  ' > 3 |test(\'Test\', () => {\n' +
+                                  '   4 |    return \'yo\';\n' +
+                                  '   5 |});'
+                    });
+                });
+        });
     });
 
     describe('Selector', function () {

diff --git a/test/server/data/test-suites/fixture-is-missing/testfile.js b/test/server/data/test-suites/fixture-is-missing/testfile.js
@@ -0,0 +1,6 @@
+// fixture `Fixture`
+
+test('Test', () => {
+    return 'yo';
+});
+