Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add --page-load-timeout #1645

Closed
AlexanderMoskovkin opened this issue Jul 24, 2017 · 5 comments
Closed

Add --page-load-timeout #1645

AlexanderMoskovkin opened this issue Jul 24, 2017 · 5 comments
Assignees
@AlexanderMoskovkin
Labels
STATE: Auto-locked An issue has been automatically locked by the Lock bot. SYSTEM: API TYPE: enhancement The accepted proposal for future implementation.
Milestone
Sprint #9

Comments

@AlexanderMoskovkin
Copy link
Contributor

AlexanderMoskovkin commented Jul 24, 2017 •
edited
Loading

(follow up #1521)
TestCafe starts tests when the DomContentLoaded event is raised. window.load event is raised with some delay sometimes.
Some pages executes page preparation scripts on the window.load event so we should wait for it. But it's possible you wouldn't like to wait additional timeouts so we should provide an ability to set this timeout to 0.

It'll be 5 seconds by default.

Also add a per-test option via setPageLoadTimeout(<ms>)
@AlexanderMoskovkin AlexanderMoskovkin added SYSTEM: API TYPE: enhancement The accepted proposal for future implementation. labels Jul 24, 2017
@AlexanderMoskovkin AlexanderMoskovkin added this to the Sprint #8 milestone Jul 24, 2017
@AlexanderMoskovkin AlexanderMoskovkin self-assigned this Jul 24, 2017
@inikulin
Copy link
Contributor

Shouldn't it be a per-test API options as well?

@AlexanderMoskovkin
Copy link
Contributor Author

do you mean like setTestSpeed ?

@inikulin
Copy link
Contributor

Yes

@AlexanderMoskovkin
Copy link
Contributor Author

I agree

@AlexanderMoskovkin AlexanderMoskovkin mentioned this issue Jul 24, 2017
Merged
AlexanderMoskovkin added a commit to AlexanderMoskovkin/testcafe that referenced this issue Jul 25, 2017
@AlexanderMoskovkin
Implement --page-load-timeout (closes DevExpress#1645)
48f9e33
AlexanderMoskovkin added a commit to AlexanderMoskovkin/testcafe that referenced this issue Jul 25, 2017
@AlexanderMoskovkin
Implement --page-load-timeout (closes DevExpress#1645)
fe383f7
AlexanderMoskovkin added a commit to AlexanderMoskovkin/testcafe that referenced this issue Jul 25, 2017
@AlexanderMoskovkin
Implement --page-load-timeout (closes DevExpress#1645)
875be7f
AlexanderMoskovkin added a commit to AlexanderMoskovkin/testcafe that referenced this issue Aug 24, 2017
@AlexanderMoskovkin
Implement --page-load-timeout (closes DevExpress#1645)
67f5d5a
AlexanderMoskovkin added a commit to AlexanderMoskovkin/testcafe that referenced this issue Aug 31, 2017
@AlexanderMoskovkin
Implement --page-load-timeout (closes DevExpress#1645)
cfccdf9
AlexanderMoskovkin added a commit to AlexanderMoskovkin/testcafe that referenced this issue Sep 8, 2017
@AlexanderMoskovkin
Implement --page-load-timeout (closes DevExpress#1645)
62d97f3
AlexanderMoskovkin added a commit to AlexanderMoskovkin/testcafe that referenced this issue Sep 12, 2017
@AlexanderMoskovkin
Implement --page-load-timeout (closes DevExpress#1645)
defd496
@lock
Copy link

lock bot commented Mar 28, 2019

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.

@lock lock bot added the STATE: Auto-locked An issue has been automatically locked by the Lock bot. label Mar 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 28, 2019
kirovboris pushed a commit to kirovboris/testcafe-phoenix that referenced this issue Dec 18, 2019
@AlexanderMoskovkin @kirovboris
Implement --page-load-timeout (closes DevExpress#1645) (DevExpress#1648)
0c56f85 
* Implement --page-load-timeout (closes DevExpress#1645)

* Fix tests

* Apply remarks

* Fix tests

* Get rid of window.self usage (follow up DevExpress#632)

* Remove redundant lines

* Reduce default page load timeout
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AlexanderMoskovkin AlexanderMoskovkin

Labels
STATE: Auto-locked An issue has been automatically locked by the Lock bot. SYSTEM: API TYPE: enhancement The accepted proposal for future implementation.
Projects
None yet
Milestone
Sprint #9
Development

No branches or pull requests
2 participants
@inikulin @AlexanderMoskovkin