Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SelectText and SelectTextAreaContent TypeScript definitions don't match documentation #1697

Closed
AlexanderMoskovkin opened this issue Aug 14, 2017 · 1 comment · Fixed by #1695
Assignees
Labels
STATE: Auto-locked An issue has been automatically locked by the Lock bot. TYPE: bug The described behavior is considered as wrong (bug).
Milestone

Comments

@AlexanderMoskovkin
Copy link
Contributor

Only the first argument (selector) should be required, others should be optional

@AlexanderMoskovkin AlexanderMoskovkin added the TYPE: bug The described behavior is considered as wrong (bug). label Aug 14, 2017
@AlexanderMoskovkin AlexanderMoskovkin added this to the Sprint #9 milestone Aug 14, 2017
AlexanderMoskovkin pushed a commit that referenced this issue Aug 15, 2017
* Change `selectText()` to match documentation

Change `selectText()` required parameters to match documentation.  In the documentation ([see here](https://devexpress.github.io/testcafe/documentation/test-api/actions/select-text.html)), it states that only the first parameter is required which seems to make sense since you wouldn't want to give all three parameters in all situations. 

If the `startPos` and `endPos` are not made optional, then a build error occurs.

* fix and test
@lock
Copy link

lock bot commented Mar 28, 2019

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.

@lock lock bot added the STATE: Auto-locked An issue has been automatically locked by the Lock bot. label Mar 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 28, 2019
kirovboris pushed a commit to kirovboris/testcafe-phoenix that referenced this issue Dec 18, 2019
…evExpress#1695)

* Change `selectText()` to match documentation

Change `selectText()` required parameters to match documentation.  In the documentation ([see here](https://devexpress.github.io/testcafe/documentation/test-api/actions/select-text.html)), it states that only the first parameter is required which seems to make sense since you wouldn't want to give all three parameters in all situations. 

If the `startPos` and `endPos` are not made optional, then a build error occurs.

* fix and test
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
STATE: Auto-locked An issue has been automatically locked by the Lock bot. TYPE: bug The described behavior is considered as wrong (bug).
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants