Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Configuration] Fix wrong warning for not well-formed tsconfig.json file #4154

Closed
miherlosev opened this issue Aug 14, 2019 · 1 comment
Closed

[Configuration] Fix wrong warning for not well-formed tsconfig.json file #4154

miherlosev opened this issue Aug 14, 2019 · 1 comment
Labels
STATE: Auto-locked An issue has been automatically locked by the Lock bot. SYSTEM: configuration storage TYPE: bug The described behavior is considered as wrong (bug).

Comments

@miherlosev
Copy link
Contributor

miherlosev commented Aug 14, 2019 •
edited
Loading

We display for not well-formed configuration file (.testcaferc.json, tsconfig.json) the error message for hard-coded file name

testcafe/src/notifications/warning-message.js

Line 17 in cb184b0

cannotParseConfigFile: "Failed to parse the '.testcaferc.json' file.\n\nThis file is not a well-formed JSON file.",

So, if the tsconfig.json is not well-formed, we display the message about the .testcaferc.json file.

Need to pass the configuration filename for this template.
@miherlosev miherlosev added TYPE: bug The described behavior is considered as wrong (bug). SYSTEM: configuration storage labels Aug 14, 2019
@miherlosev miherlosev self-assigned this Aug 14, 2019
@lock
Copy link

lock bot commented Sep 16, 2019

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.

@lock lock bot added the STATE: Auto-locked An issue has been automatically locked by the Lock bot. label Sep 16, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 16, 2019
kirovboris pushed a commit to kirovboris/testcafe-phoenix that referenced this issue Dec 18, 2019
@miherlosev @kirovboris
Fix wrong warning message for not well-formed typescript configuratio…
0abf0b0 
…n file (close DevExpress#4154) (DevExpress#4237)

* initial

* add typings for debug and json5 modules
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
STATE: Auto-locked An issue has been automatically locked by the Lock bot. SYSTEM: configuration storage TYPE: bug The described behavior is considered as wrong (bug).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@miherlosev