Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript error when using testcafe version 1.6.0 #4405

Closed
zsid opened this issue Oct 18, 2019 · 5 comments · Fixed by #4407
Closed

Typescript error when using testcafe version 1.6.0 #4405

zsid opened this issue Oct 18, 2019 · 5 comments · Fixed by #4407
Labels
AREA: server AREA: TypeScript definitions FREQUENCY: critical STATE: Auto-locked An issue has been automatically locked by the Lock bot. SYSTEM: compiler TYPE: bug The described behavior is considered as wrong (bug).
Milestone
Sprint #44

Comments

@zsid
Copy link

zsid commented Oct 18, 2019

What is the Current behavior?

  • I am currently using create react app plus "typescript": "3.6.0". When I upgraded from version 1.5.0 to v1.6.0 and I ran my tests I get this error:
 Property 'page' does not exist on type 'It'.
Property 'page' does not exist on type 'It'.
Property 'page' does not exist on type 'It'.

Looks like this is similar to or maybe the same as the declare var test on global scope issue

What is the Expected behavior?

I would expect to run the tests.

Your Environment details:

  • testcafe version: testcafe -v1.6.0
  • typescript: 3.6.0
  • node.js version: node -v10.15.3
  • browser name and version: I run it headless
  • platform and version: macOS Mojava 10.14.6
  • other:
@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Oct 18, 2019
@Meemaw
Copy link

Meemaw commented Oct 19, 2019

Facing same issues

@AlexKamaev AlexKamaev self-assigned this Oct 21, 2019
@AlexKamaev
Copy link
Contributor

@zsid @Meemaw
Could you please provide more details on how to reproduce the issue on our side? We would really appreciate it if you prepare a sample project which demonstrates the issue.

@need-response-app need-response-app bot removed the STATE: Need response An issue that requires a response or attention from the team. label Oct 21, 2019
@AlexKamaev AlexKamaev added the STATE: Need clarification An issue lacks information for further research. label Oct 21, 2019
@zsid
Copy link
Author

zsid commented Oct 21, 2019

@AlexKamaev - I have created a branch called typescript error and put the error I am getting in the README.

It is slightly different error from the original one but the underlining problem is the same - typescript is using jest for the type checking etc.

@need-response-app need-response-app bot added the STATE: Need response An issue that requires a response or attention from the team. label Oct 21, 2019
@no-response no-response bot removed the STATE: Need clarification An issue lacks information for further research. label Oct 21, 2019
@AlexKamaev
Copy link
Contributor

@zsid
Thank you.
I was able to reproduce the issue using your example.
For the team: check this commit at first: bfd8985

@need-response-app need-response-app bot removed the STATE: Need response An issue that requires a response or attention from the team. label Oct 21, 2019
@AlexKamaev AlexKamaev removed their assignment Oct 21, 2019
@AlexKamaev AlexKamaev modified the milestones: Planned, Sprint #44 Oct 21, 2019
AndreyBelym added a commit to AndreyBelym/testcafe that referenced this issue Oct 21, 2019
@AndreyBelym
Fix a conflict with Jest type definitions (closes DevExpress#4405)
716cceb
@AndreyBelym AndreyBelym mentioned this issue Oct 21, 2019
Merged
miherlosev pushed a commit that referenced this issue Oct 22, 2019
@AndreyBelym @miherlosev
Fix a conflict with Jest type definitions (closes #4405) (#4407)
b01c181
@AndreyBelym AndreyBelym mentioned this issue Oct 30, 2019
Closed
@lock
Copy link

lock bot commented Nov 1, 2019

This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow.

@lock lock bot added the STATE: Auto-locked An issue has been automatically locked by the Lock bot. label Nov 1, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Nov 1, 2019
kirovboris pushed a commit to kirovboris/testcafe-phoenix that referenced this issue Dec 18, 2019
@AndreyBelym @kirovboris
Fix a conflict with Jest type definitions (closes DevExpress#4405) (D…
7d885f0 
…evExpress#4407)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
AREA: server AREA: TypeScript definitions FREQUENCY: critical STATE: Auto-locked An issue has been automatically locked by the Lock bot. SYSTEM: compiler TYPE: bug The described behavior is considered as wrong (bug).
Projects
None yet
Milestone
Sprint #44
Development

Successfully merging a pull request may close this issue.

Fix a conflict with Jest type definitions (closes #4405) AndreyBelym/testcafe
3 participants
@AlexKamaev @Meemaw @zsid