Show the original error message when a browser provider can't be loaded #4522
Labels
AREA: server
HELP WANTED
STATE: Auto-locked
An issue has been automatically locked by the Lock bot.
SYSTEM: browser natives
TYPE: enhancement
The accepted proposal for future implementation.
Comments
AndreyBelym
added
TYPE: enhancement
danwenzel
pushed a commit
to danwenzel/testcafe
that referenced
this issue
Jan 23, 2020
Fixes DevExpress#4522 and DevExpress#4673. First uses `require.resolve`, which will only throw an error if the provider module itself doesn't exist. If it does exist, we then use `require` to load the module, not catching errors. That way, any errors caused by a 3rd party dependency will show up.
danwenzel
pushed a commit
to danwenzel/testcafe
that referenced
this issue
Jan 23, 2020
Fixes DevExpress#4522 and DevExpress#4673. First uses `require.resolve`, which will only throw an error if the provider module itself doesn't exist. If it does exist, we then use `require` to load the module, not catching errors. That way, any errors caused by a 3rd party dependency will show up.
miherlosev
pushed a commit
to danwenzel/testcafe
that referenced
this issue
Mar 19, 2020
Fixes DevExpress#4522 and DevExpress#4673. First uses `require.resolve`, which will only throw an error if the provider module itself doesn't exist. If it does exist, we then use `require` to load the module, not catching errors. That way, any errors caused by a 3rd party dependency will show up.
miherlosev
added a commit
that referenced
this issue
Mar 23, 2020
* Only catch error if provider module itself does not exist Fixes #4522 and #4673. First uses `require.resolve`, which will only throw an error if the provider module itself doesn't exist. If it does exist, we then use `require` to load the module, not catching errors. That way, any errors caused by a 3rd party dependency will show up. * add test * update device for browserstack * revert browserstack device version Co-authored-by: miherlosev <[email protected]>
|
This thread has been automatically locked since it is closed and there has not been any recent activity. Please open a new issue for related bugs or feature requests. We recommend you ask TestCafe API, usage and configuration inquiries on StackOverflow. |
lock
bot
added
the
STATE: Auto-locked
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
What is your Test Scenario?
Try to use a browser provider that has a missing third-party dependency.
What are you suggesting?
Show the original Node.js require error that references the missing module when requiring a browser provider fails.
What alternatives have you considered?
Run
node -e "require.resolve('testcafe-browser-provider-PROVIDER')"in the TestCafe installation directory.Additional context
DevExpress/testcafe-browser-provider-browserstack#71
The text was updated successfully, but these errors were encountered: