Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestCafe hangs if the specified screenshots directory contains forbidden symbols #681

Closed
AndreyBelym opened this issue Jul 21, 2016 · 4 comments
Closed

TestCafe hangs if the specified screenshots directory contains forbidden symbols #681

AndreyBelym opened this issue Jul 21, 2016 · 4 comments
Assignees
@AndreyBelym
Labels
AREA: server STATE: Auto-locked An issue has been automatically locked by the Lock bot. SYSTEM: CLI A command-line interface issue. SYSTEM: runner TYPE: bug The described behavior is considered as wrong (bug).

Comments

@AndreyBelym
Copy link
Contributor

mkdirp falls into infinite recursion, if the specified path contains some forbidden symbols, e.g. ':' on Windows. To reproduce, just try:

node .\bin\testcafe.js remote test.js -s .\scrs:\
@AndreyBelym AndreyBelym added TYPE: bug The described behavior is considered as wrong (bug). SYSTEM: runner AREA: server SYSTEM: CLI A command-line interface issue. labels Jul 21, 2016
@AndreyBelym
Copy link
Contributor Author

AndreyBelym commented Jul 21, 2016 •
edited
Loading

https://github.com/substack/node-mkdirp/issues/70, almost two years old 😭

@inikulin
Copy link
Contributor

We can consider switching to another package if this one is abandoned

@AlexanderMoskovkin AlexanderMoskovkin modified the milestone: Sprint #5 Feb 15, 2017
@inikulin inikulin added this to the Planned milestone Mar 21, 2017
@AndreyBelym AndreyBelym modified the milestones: Planned, Sprint #17 Aug 30, 2018
@AndreyBelym
Copy link
Contributor Author

I'm working on it.

AndreyBelym added a commit to AndreyBelym/testcafe that referenced this issue Sep 5, 2018
@AndreyBelym
Check screenshot paths for forbidden symbols(closes DevExpress#681)
7c35698
AndreyBelym added a commit to AndreyBelym/testcafe that referenced this issue Sep 10, 2018
@AndreyBelym
Check screenshot paths for forbidden symbols(closes DevExpress#681)
bcfd6f1
@AndreyBelym AndreyBelym modified the milestones: Sprint #17, Sprint #18 Sep 17, 2018
AndreyBelym added a commit to AndreyBelym/testcafe that referenced this issue Sep 18, 2018
@AndreyBelym
Check screenshot paths for forbidden symbols(closes DevExpress#681)
53a975a
AndreyBelym added a commit to AndreyBelym/testcafe that referenced this issue Sep 20, 2018
@AndreyBelym
Check screenshot paths for forbidden symbols(closes DevExpress#681)
bc8f913
AndreyBelym added a commit to AndreyBelym/testcafe that referenced this issue Sep 27, 2018
@AndreyBelym
Check screenshot paths for forbidden symbols(closes DevExpress#681)
6716b22
@giorgiosironi giorgiosironi mentioned this issue Jan 8, 2019
Closed
@lock
Copy link

lock bot commented Mar 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs or feature requests. For TestCafe API, usage and configuration inquiries, we recommend asking them on StackOverflow.

@lock lock bot added the STATE: Auto-locked An issue has been automatically locked by the Lock bot. label Mar 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 28, 2019
kirovboris pushed a commit to kirovboris/testcafe-phoenix that referenced this issue Dec 18, 2019
@AndreyBelym @kirovboris
Check screenshot paths for forbidden symbols(closes DevExpress#681) (D…
85c0fd4 
…evExpress#2820)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AndreyBelym AndreyBelym

Labels
AREA: server STATE: Auto-locked An issue has been automatically locked by the Lock bot. SYSTEM: CLI A command-line interface issue. SYSTEM: runner TYPE: bug The described behavior is considered as wrong (bug).
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@inikulin @AndreyBelym @AlexanderMoskovkin