Implement TypeScript support (closes #408) #1463

inikulin · 2017-05-04T10:34:16Z

This enables built-in compilation of .ts files and type definitions for TestCafe. You need to import 'testcafe'; (in case if you don't import e.g. Selector already) to enable typings, editor support and make test files compilable:

import `testcafe`;

fixture('My fixture');

test('My test', async t => {
});

Note that tagged template literal syntax is not available for fixture and page. Use function syntax instead.

To try code completion and API hints in VSCode run npm install @inikulin/testcafe and then import '@inikulin/testcafe' in your test file.

\cc @AlexanderMoskovkin @helen-dikareva @AndreyBelym

Note that we've dropped Node 0.10 support with this feature.

testcafe-build-bot · 2017-05-04T11:07:30Z

❌ Tests for the commit 29ee325 have failed. See details:

testcafe-build-bot · 2017-05-04T11:44:50Z

❌ Tests for the commit 1c38bdb have failed. See details:

helen-dikareva · 2017-05-04T11:49:18Z

src/compiler/index.js

+        Compiler._setupSourceMapsSupport();
+    }
+
+    static getSupportedTestFileExtensions () {


We can get extensions once, after compilers' creation

ok, do not mind

helen-dikareva · 2017-05-04T12:05:10Z

src/compiler/test-file/api-based.js

+
+
+// Const
+APIBasedTestFileCompilerBase.EXPORTABLE_LIB_PATH = join(__dirname, '../../api/exportable-lib');


we can use static get for this

I think declare a const and use static get will be more in es6 style

helen-dikareva · 2017-05-04T12:11:17Z

src/compiler/test-file/formats/typescript.js

+
+    static _reportErrors (diagnostics) {
+        // NOTE: lazy load the compiler
+        var ts     = require('typescript');


may be use get for ts

testcafe-build-bot · 2017-05-04T12:23:35Z

✅ Tests for the commit 1c38bdb have passed. See details:

RichiCoder1 · 2017-05-05T20:47:16Z

package.json

    "testcafe-reporter-json": "^2.1.0",
    "testcafe-reporter-list": "^2.1.0",
    "testcafe-reporter-minimal": "^2.1.0",
    "testcafe-reporter-spec": "^2.1.1",
    "testcafe-reporter-xunit": "^2.1.0",
    "time-limit-promise": "^1.0.2",
    "tree-kill": "^1.1.0",
+    "typescript": "^2.2.2",


Is it possible to make typescript a peer dependency? Likely many projects are already going to have typescript pulled in as a dependency.

@RichiCoder1 Is there any problem with having ts as dependency? Unlike e.g. babel it has zero dependencies and package size is quite small. Moreover, if you already have ts installed package manager will more likely link already installed version.

True, but it does open yourself up to issues if Typescript releases a major version, and the typescript package is yet another package for end users. That being said, I don't feel strongly about this :)

Yeah, but we'll be open for such issues anyway, i.e. programmatical API that we use could change with a major version bump.

AndreyBelym

lgtm

helen-dikareva

:)

testcafe-build-bot · 2017-05-10T13:53:18Z

❌ Tests for the commit 96a61fc have failed. See details:

testcafe-build-bot · 2017-05-10T14:38:37Z

❌ Tests for the commit 96a61fc have failed. See details:

testcafe-build-bot · 2017-05-11T09:20:29Z

❌ Tests for the commit 96a61fc have failed. See details:

testcafe-build-bot · 2017-05-11T11:31:46Z

❌ Tests for the commit 5ef519e have failed. See details:

inikulin · 2017-05-11T15:46:10Z

@testcafe-build-bot \retest

testcafe-build-bot · 2017-05-11T16:40:59Z

❌ Tests for the commit 5ef519e have failed. See details:

AlexanderMoskovkin · 2017-05-12T07:57:50Z

The only functional test is failed. It relates to the pressKey automation in Safari. It failed in all current builds (pull requests and master branch), so it's not related to the current pull request, but I think it's because browser version was updated on BrowserStack. We are investigating it.
So, I think we can ignore this test and merge the pull request if there are no changes requests here.

* Introduce TestFileCompilerBase * Refactor compiler dir structure * Extract APIBasedTestFileCompilerBase * Update legacy api * Compiler basics * Exportable lib resolution * Basic test * Mixed deps test * Definitions * More definitions * More definitions * More definitions * More definitions * More definitions * More definitions * Test Selector definitions * More definition tests. * Compilation tests * Functional smoke tests * CLI support * Descriptions * Description * Drop node 10 support * Fix Helen's remarks.

helen-dikareva requested changes May 4, 2017

View reviewed changes

AlexanderMoskovkin approved these changes May 5, 2017

View reviewed changes

RichiCoder1 reviewed May 5, 2017

View reviewed changes

AndreyBelym approved these changes May 10, 2017

View reviewed changes

helen-dikareva approved these changes May 10, 2017

View reviewed changes

inikulin added 19 commits May 11, 2017 14:02

Introduce TestFileCompilerBase

3bfe8e1

Refactor compiler dir structure

77b5049

Extract APIBasedTestFileCompilerBase

b80d410

Update legacy api

089eb16

Compiler basics

943f5b6

Exportable lib resolution

ae22580

Basic test

6439287

Mixed deps test

2b47a3d

Definitions

51a632b

More definitions

702385a

More definitions

ddc1f77

More definitions

5066883

More definitions

eec437c

More definitions

0e395e9

More definitions

914fc1b

Test Selector definitions

f14b755

More definition tests.

87d43cf

Compilation tests

1b4ada1

Functional smoke tests

4d0240e

inikulin added 5 commits May 11, 2017 14:02

CLI support

684dc8a

Descriptions

2d944b3

Description

c2daa41

Drop node 10 support

6fdef6a

Fix Helen's remarks.

5ef519e

inikulin force-pushed the gh408 branch from 96a61fc to 5ef519e Compare May 11, 2017 11:02

inikulin merged commit 6a2a951 into DevExpress:master May 12, 2017

inikulin deleted the gh408 branch May 12, 2017 10:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement TypeScript support (closes #408) #1463

Implement TypeScript support (closes #408) #1463

inikulin commented May 4, 2017 •

edited

Loading

testcafe-build-bot commented May 4, 2017

testcafe-build-bot commented May 4, 2017

helen-dikareva May 4, 2017

helen-dikareva May 10, 2017

helen-dikareva May 4, 2017

helen-dikareva May 10, 2017

helen-dikareva May 4, 2017

helen-dikareva May 10, 2017

testcafe-build-bot commented May 4, 2017

RichiCoder1 May 5, 2017

inikulin May 8, 2017

RichiCoder1 May 10, 2017

inikulin May 10, 2017

AndreyBelym left a comment

helen-dikareva left a comment

testcafe-build-bot commented May 10, 2017

testcafe-build-bot commented May 10, 2017

testcafe-build-bot commented May 11, 2017

testcafe-build-bot commented May 11, 2017

inikulin commented May 11, 2017

testcafe-build-bot commented May 11, 2017

AlexanderMoskovkin commented May 12, 2017



		// Const
		APIBasedTestFileCompilerBase.EXPORTABLE_LIB_PATH = join(__dirname, '../../api/exportable-lib');

Implement TypeScript support (closes #408) #1463

Implement TypeScript support (closes #408) #1463

Conversation

inikulin commented May 4, 2017 • edited Loading

testcafe-build-bot commented May 4, 2017

testcafe-build-bot commented May 4, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

testcafe-build-bot commented May 4, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AndreyBelym left a comment

Choose a reason for hiding this comment

helen-dikareva left a comment

Choose a reason for hiding this comment

testcafe-build-bot commented May 10, 2017

testcafe-build-bot commented May 10, 2017

testcafe-build-bot commented May 11, 2017

testcafe-build-bot commented May 11, 2017

inikulin commented May 11, 2017

testcafe-build-bot commented May 11, 2017

AlexanderMoskovkin commented May 12, 2017

inikulin commented May 4, 2017 •

edited

Loading