fix Clear out the localStorage after test (close #1546)
#1590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Tests for the commit f8f1a9e have failed. See details: |
|
@testcafe-build-bot \retest |
|
❌ Tests for the commit f8f1a9e have failed. See details: |
|
@testcafe-build-bot \retest |
|
✅ Tests for the commit f8f1a9e have passed. See details: |
AlexanderMoskovkin
approved these changes
Jul 10, 2017
helen-dikareva
requested changes
Jul 10, 2017
| fixture `Storages` | ||
| .page `http://localhost:3000/fixtures/driver/pages/set-value-to-storages.html`; | ||
|
|
||
| const saveNativeStorageKey = ClientFunction(storageName => { |
There was a problem hiding this comment.
Let's call if setNativeStorageKey .
And we can do not return value from this method
helen-dikareva
approved these changes
Jul 10, 2017
|
✅ Tests for the commit 3d13a96 have passed. See details: |
AlexanderMoskovkin
pushed a commit
to AndreyBelym/testcafe
that referenced
this pull request
Jul 20, 2017
…evExpress#1590) * fix `Clear out the localStorage after test` (close DevExpress#1546) * fix review's issues
kirovboris
pushed a commit
to kirovboris/testcafe-phoenix
that referenced
this pull request
Dec 18, 2019
…evExpress#1590) * fix `Clear out the localStorage after test` (close DevExpress#1546) * fix review's issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.