should restore cookie correctly when using useRole with the preserveUrl option (closes #2282) #2285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Tests for the commit f2eb748 have passed. See details: |
AlexKamaev
changed the title
AlexanderMoskovkin
requested review from
helen-dikareva
and removed request for
AndreyBelym
AlexanderMoskovkin
approved these changes
Apr 5, 2018
helen-dikareva
requested changes
Apr 9, 2018
|
|
||
| this._assignFrom(obj, true); | ||
| } | ||
|
|
||
| _getAssignableProperties () { | ||
| return [ | ||
| { name: 'url', type: urlArgument, required: true }, | ||
| { name: 'storages', type: nullableStringArgument } | ||
| { name: 'stateSnapshot', type: nullableStringArgument } |
There was a problem hiding this comment.
stateSnapshot isn't 'string or null' anymore, is it?
| if (!document.cookie || document.cookie === 'auth=false') | ||
| location.href = './login.html'; | ||
| else { | ||
| var result = document.getElementById('result'); |
There was a problem hiding this comment.
please add new line after new var
|
|
||
| test('Login and save cookies in the role', async t => { | ||
| await t | ||
| .useRole(role) |
There was a problem hiding this comment.
Can we move useRole to fixture.beforeEach?
helen-dikareva
approved these changes
Apr 10, 2018
|
✅ Tests for the commit 2ff8010 have passed. See details: |
kirovboris
pushed a commit
to kirovboris/testcafe-phoenix
that referenced
this pull request
Dec 18, 2019
…rl option (closes DevExpress#2282) (DevExpress#2285) * should restore cookie correctly when using useRole with the preserveUrl option (closes DevExpress#2282) * changes after request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.