fix '${BROWSER} resolves to undefined in screenshot pattern' (close #2742) #2794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Tests for the commit 00266d3 have failed. See details: |
AndreyBelym
reviewed
Aug 31, 2018
test/server/path-pattern-test.js
Outdated
| ].join('#') + '.png'; | ||
|
|
||
| const pathPattern = createPathPattern(pattern, data); | ||
|
|
||
| const path = pathPattern.getPath(false); | ||
|
|
||
| expect(path).eql(expectedParsedPattern); | ||
| expect(path).contains(expectedParsedPattern); |
There was a problem hiding this comment.
Is it an intentional change?
There was a problem hiding this comment.
Good catch. It's from development. I will fix it
|
❌ Tests for the commit 97a960f have failed. See details: |
|
@testcafe-build-bot retest |
|
❌ Tests for the commit 97a960f have failed. See details: |
|
@testcafe-build-bot retest |
AndreyBelym
approved these changes
Aug 31, 2018
|
✅ Tests for the commit 97a960f have passed. See details: |
kirovboris
pushed a commit
to kirovboris/testcafe-phoenix
that referenced
this pull request
Dec 18, 2019
…evExpress#2742) (DevExpress#2794) * fix '${BROWSER} resolves to undefined in screenshot pattern' (close DevExpress#2742) * fix review issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AndreyBelym
Review only two files:
test/server/path-pattern-test.jssrc/screenshots/path-pattern.js