do not check regex optionally (closes #2074) #2980
Conversation
|
❌ Tests for the commit af8ee78 have failed. See details: |
6 similar comments
|
❌ Tests for the commit af8ee78 have failed. See details: |
|
❌ Tests for the commit af8ee78 have failed. See details: |
|
❌ Tests for the commit af8ee78 have failed. See details: |
|
❌ Tests for the commit af8ee78 have failed. See details: |
|
❌ Tests for the commit af8ee78 have failed. See details: |
|
❌ Tests for the commit af8ee78 have failed. See details: |
| @@ -140,6 +173,39 @@ describe('Compiler', function () { | |||
|
|
|||
|
|
|||
| describe('TypeScript', function () { | |||
| it('Should compile test defined in separate module if option is enabled', function () { | |||
There was a problem hiding this comment.
Why does we need addtional tests written with TypeScript and CoffeeScript?
There was a problem hiding this comment.
We have several compilers and every on them has it's own set of similar tests. It's true that I modified base behavior which affects all of the compilers at the same time, but I think it'd better to have full set of tests
| @@ -47,6 +47,39 @@ describe('Compiler', function () { | |||
| }); | |||
|
|
|||
| describe('ES-next', function () { | |||
| it('Should compile test defined in separate module if option is enabled', function () { | |||
| const sources = [ | |||
There was a problem hiding this comment.
Also add tests for negative cases:
If there are no test and/or fixture definitions into imported files, then TestCafe should report clear error messages.
AlexKamaev
changed the title
|
❌ Tests for the commit 4e1c527 have failed. See details: |
|
❌ Tests for the commit 0165e58 have failed. See details: |
|
@testcafe-build-bot retest |
|
❌ Tests for the commit 0165e58 have failed. See details: |
|
❌ Tests for the commit 8c68e4e have failed. See details: |
AlexKamaev
changed the title
|
❌ Tests for the commit 8c68e4e have failed. See details: |
3 similar comments
|
❌ Tests for the commit 8c68e4e have failed. See details: |
|
❌ Tests for the commit 8c68e4e have failed. See details: |
|
❌ Tests for the commit 8c68e4e have failed. See details: |
|
@testcafe-build-bot retest |
|
❌ Tests for the commit 4735c0d have failed. See details: |
|
❌ Tests for the commit 6414a8a have failed. See details: |
|
❌ Tests for the commit 6414a8a have failed. See details: |
|
❌ Tests for the commit 6414a8a have failed. See details: |
|
❌ Tests for the commit 6414a8a have failed. See details: |
|
❌ Tests for the commit 6414a8a have failed. See details: |
|
❌ Tests for the commit 6414a8a have failed. See details: |
|
❌ Tests for the commit 6414a8a have failed. See details: |
|
❌ Tests for the commit 6414a8a have failed. See details: |
|
❌ Tests for the commit 6414a8a have failed. See details: |
|
❌ Tests for the commit 6414a8a have failed. See details: |
3 similar comments
|
❌ Tests for the commit 6414a8a have failed. See details: |
|
❌ Tests for the commit 6414a8a have failed. See details: |
|
❌ Tests for the commit 6414a8a have failed. See details: |
test/server/runner-test.js
Outdated
| @@ -294,6 +294,16 @@ describe('Runner', () => { | |||
| expect(err.message).eql('No test file specified.'); | |||
| }); | |||
| }); | |||
|
|
|||
| it('Should raise an error if the source and imported midule have no tests', () => { | |||
There was a problem hiding this comment.
typo midule
AFAIK we should check all text lines including comments and test names.
|
❌ Tests for the commit fdb6804 have failed. See details: |
|
❌ Tests for the commit fdb6804 have failed. See details: |
|
❌ Tests for the commit fdb6804 have failed. See details: |
|
❌ Tests for the commit fdb6804 have failed. See details: |
|
❌ Tests for the commit fdb6804 have failed. See details: |
3 similar comments
|
❌ Tests for the commit fdb6804 have failed. See details: |
|
❌ Tests for the commit fdb6804 have failed. See details: |
|
❌ Tests for the commit fdb6804 have failed. See details: |
|
✅ Tests for the commit fdb6804 have passed. See details: |
|
ping |
VasilyStrelyaev
added
DOCUMENTATION: required
and removed
DOCUMENTATION: required
labels
No description provided.