Role definition changed #4307
Merged
Role definition changed #4307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ Tests for the commit 8ba9c00 have failed. See details: |
|
❌ Tests for the commit d384b4d have failed. See details: |
|
❌ Tests for the commit 1f1b2bd have failed. See details: |
|
❌ Tests for the commit 7b16d8d have failed. See details: |
kirovboris
requested changes
Sep 27, 2019
|
✅ Tests for the commit 7b16d8d have passed. See details: |
aleks-pro
previously approved these changes
Oct 1, 2019
|
✅ Tests for the commit 629787a have passed. See details: |
kirovboris
pushed a commit
to kirovboris/testcafe-phoenix
that referenced
this pull request
Dec 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UPD by @AndreyBelym:
Actual changes to definitions are made by @helen-dikareva.
I've split our huge definition file into sub-definitions and added assembly system that relies on Mustache.
Tests are copied (with some modifications) from test/server/data/test-suites/typescript-defs.