add missing video declaration for runner #4636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Tests for the commit be98ee2 have passed. See details: |
kirovboris
approved these changes
Jan 13, 2020
VasilyStrelyaev
requested changes
Jan 14, 2020
There was a problem hiding this comment.
Thank you, @vitalics!
Please note that the encodingOptions parameter can take any ffmpeg options. Therefore, we should either define it as any or find an up-to-date definition for ffmpeg options.
AndreyBelym
reviewed
Jan 16, 2020
AndreyBelym
reviewed
Jan 23, 2020
There was a problem hiding this comment.
Could you please add a call to .video with some options to this file in order to cover your changes by our autotests?
|
❌ Tests for the commit 4084df0 have failed. See details: |
VasilyStrelyaev
approved these changes
Jan 28, 2020
|
✅ Tests for the commit 6f6272f have passed. See details: |
AndreyBelym
approved these changes
Jan 28, 2020
|
✅ Tests for the commit 0dbdcc6 have passed. See details: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add missing video declaration and interfaces for runner