-
Notifications
You must be signed in to change notification settings - Fork 5
Developer Workflow
// drafting
DevProgress is a team of kick ass developers using their skills and expertise to create tools that will help elect Hillary Clinton and other Democratic and progressive candidates.
Here is outline of our standard break down of tasks, pushing code and releasing to production.
Our standard baseline code is lightweight client only react web apps on gh-pages.
- Javascript.
- React. Javascript driven css.
- Webpack npm dev and build.
- Automated Testing (?)
- Continuous Delivery (?)
Trello is used to track all our projects at a high level.
It's not something we use to track tasks at a project level.
This is where ideas and campaign requests are first created.
Developers can visit the trello board to see what projects are new, inflight and done.
Slack is our discussion forum for all projects.
This is where technical decisions get made.
Developers can use slack to join the conversation around any particular project and discover how they can help.
Once a technical approach has been agreed upon in slack the collaboration moves to github to track tasks, branch and code review.
We only really have 2 types of branches.
- Master. This is what goes to Production.
- Whatever branch you are working on. This is where you start by branching of master.
To get your work back to the Master branch you will need to create a Pull Request and have 2 people add a "+1" comment on it.
All code needs to be reviewed before it is merged back to the master
branch.
- Pull the branch in question.
- Run it locally.
- Inspect the code changes and offer any tips on how it may well be improved
- If you're happy with it then add a "+1" comment.
With two "+1" comments on any given Pull Request the original creator is free to approve the Pull Request.
We create github issues. Anyone is free to add issues to any given Project.
Once a developer begins working on an issue they assign themselves to it so others know it is in progress.
...
Github Pages.
Our strategy for merging from master
to gh-pages
is currently a work in progress. Tbc.