Skip to content
This repository has been archived by the owner on Feb 15, 2022. It is now read-only.

Enhance backtester: support peroid, min_peroids param and rsi_macd strategy #368

Merged
merged 2 commits into from
Jul 8, 2017
Merged

Enhance backtester: support peroid, min_peroids param and rsi_macd strategy #368

merged 2 commits into from
Jul 8, 2017

Conversation

fasheng
Copy link
Contributor

@fasheng fasheng commented Jul 8, 2017

The new added rsi_macd strategy set min_peroids to 200 as default value which is different than others, so I support it in backtester firstly.

BTW, looks srsi_macd is a better name than rsi_macd for it use Stochastic RSI in fact...

@LeMoussel
Copy link

Do you have some articles about rsi_macd / Stochastic RSI strategy ?

@talvasconcelos
Copy link
Contributor

Hi, it was really my first PR and i screwed up the naming. Indeed the srsi_macd is a better name. BTW i'm not familiar with this backtester, what does it do and do i use it?

@fasheng
Copy link
Contributor Author

fasheng commented Jul 8, 2017

Hi @talvasconcelos, thanks for your code. So you could decide the name together with @carlos8f :)

And backtester is a wrapper for zenbot sim that could help us to find the best strategy options, for example:

zenbot backfill gdax.BTC-USD --days 7
backtester.js gdax.BTC-USD --days 7 --strategy rsi_macd

After all tests finished, it will generate a result CSV file and we could choice the options in the list.

But the default option ranges could not cover all cases, so we need custom them in backtest.js, too.
https://github.com/carlos8f/zenbot/blob/master/scripts/auto_backtester/backtester.js#L168

Copy link
Owner

@DeviaVir DeviaVir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 useful stuff

@DeviaVir DeviaVir merged commit c0c79bc into DeviaVir:master Jul 8, 2017
@talvasconcelos
Copy link
Contributor

This is awesome... i'll make a PR today with changed name then. I'm also making a new strategy with CCI and SRSI than i hope to push today. This tool is awesome as i run endless sims testing different parameters!! Hope it gets merged soon so i can test it.

Thanks for this

@talvasconcelos
Copy link
Contributor

sent the pr with the strategy name change, guess it screws your work, sorry man. also fixed sma, take a look and see if it good like that. hope today I'll push a new strat...

@fasheng
Copy link
Contributor Author

fasheng commented Jul 8, 2017

Just fine, I will review the code soon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants