Add Dockerfile for arm64 #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Image can be built on a normal x86_64 linux PC with installed qemu-aarch64-static and properly configured binfmt_misc by running docker build --platform linux/arm64/v8 -f Dockerfile-debian-arm64 -t stf . or buildah bud --platform linux/arm64/v8 -f Dockerfile-debian-arm64 -t stf . Signed-off-by: Ivan Mironov <[email protected]>
|
It seems that bundletool installation is missing. Could you add it? |
|
I used https://github.com/DeviceFarmer/stf/blob/master/Dockerfile-debian-armhf as a template and bundletool is not mentioned there. Also, I successfully built an arm64 docker image and tested it - it works just fine. Is bundletool really needed? |
koral--
approved these changes
Sep 27, 2023
|
It is used for AAB installation: 841b092 OK, I think it's fine to merge this PR. |
im-0
added a commit
to im-0/stf
that referenced
this pull request
Sep 29, 2023
This is a minor cosmetic change. Missed this in DeviceFarmer#712. Signed-off-by: Ivan Mironov <[email protected]>
koral--
added a commit
that referenced
this pull request
Sep 29, 2023
This is a minor cosmetic change. Missed this in #712. Signed-off-by: Ivan Mironov <[email protected]> Co-authored-by: Karol Wrótniak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image can be built on a normal x86_64 linux PC with installed qemu-aarch64-static and properly configured binfmt_misc by running
or