Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(server): add volume support #641

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

elmarco
Copy link
Contributor

@elmarco elmarco commented Jan 24, 2025

Add server messages and API to support setting client volume.

Copy link
Member

@CBenoit CBenoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@CBenoit CBenoit enabled auto-merge (squash) January 24, 2025 16:45
@CBenoit
Copy link
Member

CBenoit commented Jan 24, 2025

CI is broken for macOS WASM check. It appears the WebAssembly/wabt project deleted the macOS 14 artifacts for the release v1.0.33 we were relying on 🤷
I’ll fix that in a separate PR.

@elmarco
Copy link
Contributor Author

elmarco commented Jan 24, 2025

it's fixed in #630 9cb217b

@CBenoit
Copy link
Member

CBenoit commented Jan 24, 2025

Indeed, I cherry-picked it to be merged in a separate PR: #642

Auto-merge is enabled on this PR, so hopefully it should be merged as soon as you rebase it on master.

Add server messages and API to support setting client volume.

Signed-off-by: Marc-André Lureau <[email protected]>
auto-merge was automatically disabled January 27, 2025 13:00

Head branch was pushed to by a user without write access

@CBenoit CBenoit merged commit a6c3651 into Devolutions:master Jan 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants