Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple Offline Viewer Bugs #14

Closed
kukreja-vikramaditya opened this issue Jul 12, 2016 · 7 comments
Closed

Simple Offline Viewer Bugs #14

kukreja-vikramaditya opened this issue Jul 12, 2016 · 7 comments
Labels
enhancement valid

Comments

@kukreja-vikramaditya
Copy link
Contributor

Added a new activity to show article data in offline mode...
Problems include -

  1. If user is downloading for first time description data is not downloaded with it so offline mode won't show anything useful
  2. Also description downloading includes wrong extra data like "Leave a comment ... etc "
@kukreja-vikramaditya
Copy link
Contributor Author

eliminated both problems by switching over to json.

@kukreja-vikramaditya
Copy link
Contributor Author

kukreja-vikramaditya commented Jul 14, 2016 •
edited
Loading

Need to figure out how to store image urls and display them programatically in offline viewer due to unknown number of image attachments

kukreja-vikramaditya added a commit that referenced this issue Feb 17, 2017
@kukreja-vikramaditya
PostDownloaderActivity improved
0727c5e 
ImagesAndMedia update
Removed unused fields in HeraldItem (#14)
Deleted ImageDownloaderService
Deleted PostDownloadService
BootBroadcastReceiver updates only 1 page of Herald
 UpdateCheckerService major updates (#4)
Reduced MAC logo size
Added placehoder for herald
removed Screen.jpg
reduced marker icon size
Gradle updates

BugFixes:
Fixed UpdateCheckerService being called for first time (#4)
kukreja-vikramaditya added a commit that referenced this issue Feb 25, 2017
@kukreja-vikramaditya
New branch merge (#54)
51b4218 
PostDownloaderActivity improved
ImagesAndMedia update
Removed unused fields in HeraldItem (#14)
Deleted ImageDownloaderService
Deleted PostDownloadService
BootBroadcastReceiver updates only 1 page of Herald
UpdateCheckerService major updates (#4)
Reduced MAC logo size
Added placehoder for herald
removed Screen.jpg
reduced marker icon size
Gradle updates
Fixed UpdateCheckerService being called for first time (#4)
Added calendar intent and fixed other minor bugs
Fixed AlarmReceiver bug which caused UpdateCheckerService being called multiple times
performance increase in HeraldAdapter and EventsAdapter #51
ViewPagerAdapter now uses SparseArray instead of List
Methods enhanced in EventItem and HeraldItem
Gazettes back at ValueEventListener
Realm version bump
Minor fixes #39 
About Us Changes
Utilities now show more columns on orientation change
Added setTheme() in IssuesActivity
Fixed IssuesActivity
Fixed "currentItem" key in MainActivity
Fixed issue #46
Added a few method docs in DHC
Added collapsable toolbar in MainActivity (#53)
@hardik124
Copy link
Contributor

@kukreja-vikramaditya can we just save all the images with a definite name , and if already exists in the sd card , it will display all images by loading from the card .
for example , both mess menu can be saved as , menu-a ,menu-c
There can be a prefix for every section ,and next 3-4 characters for the subsection , and so on ,
If this issue is still relevant , can i work on this?

@kukreja-vikramaditya
Copy link
Contributor Author

@hardik124
Currently images are downloaded using the Fresco library. Fresco uses caching to store images but it does have the option to get the bitmap. In order to solve this you need to find out a way to extract the bitmap and save it, as you suggested above, and then display it in the offline article loading activity.

@kukreja-vikramaditya
Copy link
Contributor Author

All issues marked as valid can be worked on

@hardik124
Copy link
Contributor

can we not switch to picasso ?
by that , we can store the images as well.

Or we can use getImageEncoded of fresco library , and then use fileoutputstream to save it.

@kukreja-vikramaditya
Copy link
Contributor Author

Please stick to Fresco. See http://stackoverflow.com/a/29567946/5262677 for more. Please send PR with your solution.

@Rushi98 Rushi98 removed the hard label May 21, 2018
@Devsoc-BPGC Devsoc-BPGC deleted a comment from hardik124 May 30, 2018
@Devsoc-BPGC Devsoc-BPGC deleted a comment from hardik124 May 30, 2018
@Rushi98 Rushi98 closed this as completed May 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement valid
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hardik124 @kukreja-vikramaditya @Rushi98