Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port shutter to ophyd-async #416

Closed
stan-dot opened this issue Apr 4, 2024 · 2 comments · Fixed by #480 or DiamondLightSource/hyperion#1419
Closed

Port shutter to ophyd-async #416

stan-dot opened this issue Apr 4, 2024 · 2 comments · Fixed by #480 or DiamondLightSource/hyperion#1419
Assignees
Labels
enhancement New feature or request low priority Not needed for production in the near future python Pull requests that update Python code

Comments

@stan-dot
Copy link
Contributor

stan-dot commented Apr 4, 2024

Acceptance Criteria

Shutter device is available with ophyd async on a beamline like i20-1, i03 or i04.
Proposed device name: Shutter.

Might need a 'reset' method. SampleShutter might be different from HutchShutter - the latter needs a way to reset the interlock.

current SampleShutter

in /dodal/devices/sample_shutter.py

class SampleShutter(Device):

@stan-dot stan-dot added enhancement New feature or request python Pull requests that update Python code labels Apr 4, 2024
@stan-dot
Copy link
Contributor Author

update based on discussion with beamline scientists on 16.04.
There are multiple shutters, but they are only needed at setup right now - that is they do not move during the scan.

Beamline staff are happy with shutting those manually through EPICS therefore to have this automated is low priority at the moment.

@stan-dot stan-dot added the low priority Not needed for production in the near future label Apr 17, 2024
@stan-dot stan-dot self-assigned this Apr 25, 2024
@stan-dot stan-dot linked a pull request Apr 29, 2024 that will close this issue
2 tasks
DominicOram added a commit to DiamondLightSource/hyperion that referenced this issue May 7, 2024
@stan-dot
Copy link
Contributor Author

scope unclear

failure mode of the internal commuincations
#480 (comment)

potential solution already worked on
bluesky/ophyd-async#323

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority Not needed for production in the near future python Pull requests that update Python code
Projects
Archived in project
2 participants