Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with incorrect motor types #489

Closed
DominicOram opened this issue May 1, 2024 · 1 comment
Closed

Fix issue with incorrect motor types #489

DominicOram opened this issue May 1, 2024 · 1 comment
Assignees

Comments

@DominicOram
Copy link
Contributor

Currently if you run the beamline system tests you will get an error like:

ophyd_async.core.utils.NotConnected: 
coros: NotConnected:
    gap_motor: NotConnected:
        motor_done_move: TypeError: SR04I-MO-SERVC-01:BLGAPMTR.DMOV has type int not float
        low_limit_travel: TypeError: SR04I-MO-SERVC-01:BLGAPMTR.LLM has type float not int
        high_limit_travel: TypeError: SR04I-MO-SERVC-01:BLGAPMTR.HLM has type float not int

This is due to bluesky/ophyd-async#273. We should pin dodal to this ophyd_async change to avoid this breaking in prod

Acceptance Criteria

  • The system tests pass again
@DominicOram
Copy link
Contributor Author

Fixed in afecc2c

@github-project-automation github-project-automation bot moved this from Todo This Sprint to Done in Hyperion May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
1 participant