Code

make device factory decorator#597

Code

Closed

stan-dot wants to merge 85 commits intomainDiamondLightSource/dodal:mainfrom 483-make-device_factory-decorator-to-ease-making-and-connecting-ophyd-async-devicesDiamondLightSource/dodal:483-make-device_factory-decorator-to-ease-making-and-connecting-ophyd-async-devicesCopy head branch name to clipboard

+905-365

Commits

Commits on Oct 15, 2024

• example beamline with implementation

  stan-dot

  committed
  87e9e36

  Copy full SHA for 87e9e36

• small cleanup

  stan-dot

  committed
  dee1d0e

  Copy full SHA for dee1d0e

• added controller demonstration

  stan-dot

  committed
  45828c0

  Copy full SHA for 45828c0

• fix wrong extension

  stan-dot

  committed
  2a7efa0

  Copy full SHA for 2a7efa0

• Update src/dodal/beamlines/example_beamline.py

  Show description for 8531403
  

  stan-dot

  and

  coretl

  committed
  8531403

  Copy full SHA for 8531403

• Update src/dodal/beamlines/example_beamline.py

  Show description for 0490806
  

  stan-dot

  and

  coretl

  committed
  0490806

  Copy full SHA for 0490806

• Update src/dodal/beamlines/example_beamline.py

  Show description for 39e372b
  

  stan-dot

  and

  coretl

  committed
  39e372b

  Copy full SHA for 39e372b

• Update src/dodal/beamlines/example_beamline.py

  Show description for 11b1671
  

  stan-dot

  and

  coretl

  committed
  11b1671

  Copy full SHA for 11b1671

• fix example beamline into a dataclass

  stan-dot

  committed
  28bcad1

  Copy full SHA for 28bcad1

• new-i22 as an example

  stan-dot

  committed
  698ec5b

  Copy full SHA for 698ec5b

• respond to feedback

  stan-dot

  committed
  a8a925f

  Copy full SHA for a8a925f

• respond to comments

  stan-dot

  committed
  e2a517f

  Copy full SHA for e2a517f

• initial test

  stan-dot

  committed
  cb5211e

  Copy full SHA for cb5211e

• comment out some tests to check coverage

  stan-dot

  committed
  1f139f7

  Copy full SHA for 1f139f7

• lint

  stan-dot

  committed
  42e4c2c

  Copy full SHA for 42e4c2c

• use factory name for active devices dict key

  stan-dot

  committed
  035e34a

  Copy full SHA for 035e34a

• this cannot be active devices, globals harder to mock

  stan-dot

  committed
  3caa89c

  Copy full SHA for 3caa89c

• amend the test

  stan-dot

  committed
  011f009

  Copy full SHA for 011f009

• added a red test for caching by name

  stan-dot

  committed
  543ee47

  Copy full SHA for 543ee47

• fix the tests and add the support for a name flag

  stan-dot

  committed
  01ac2ab

  Copy full SHA for 01ac2ab

• add the API for blueapi

  stan-dot

  committed
  248ea93

  Copy full SHA for 248ea93

• remove todos

  stan-dot

  committed
  dabc376

  Copy full SHA for dabc376

• unused utils deleted for coverage

  stan-dot

  committed
  ce95b44

  Copy full SHA for ce95b44

• Just one i22 now

  stan-dot

  committed
  97c4c45

  Copy full SHA for 97c4c45

• respond to comments

  stan-dot

  committed
  c277821

  Copy full SHA for c277821

• rename to device factory

  stan-dot

  committed
  f7578f9

  Copy full SHA for f7578f9

• is this enough to replace skip_device()

  stan-dot

  committed
  f298379

  Copy full SHA for f298379

• ruff

  stan-dot

  committed
  3cd8763

  Copy full SHA for 3cd8763

• remove the connect default timeout =10

  stan-dot

  committed
  63a2211

  Copy full SHA for 63a2211

• add support for the terminal use case and some tests

  stan-dot

  committed
  152ff73

  Copy full SHA for 152ff73

• fix mock status and add the new decorator@

  stan-dot

  committed
  c5b7d2e

  Copy full SHA for c5b7d2e

• fix the tests

  stan-dot

  committed
  dcb6102

  Copy full SHA for dcb6102

• delete bad comments, add good comments

  stan-dot

  committed
  ffb41ee

  Copy full SHA for ffb41ee

• ruff

  stan-dot

  committed
  826e96f

  Copy full SHA for 826e96f

• feedback response

  stan-dot

  committed
  9e0be91

  Copy full SHA for 9e0be91

• add return type annotation for testing coverage purposes

  stan-dot

  committed
  2a4c432

  Copy full SHA for 2a4c432

• respond to feedback

  stan-dot

  committed
  cb43eb9

  Copy full SHA for cb43eb9

• adapt tetramm

  stan-dot

  committed
  34d6c4e

  Copy full SHA for 34d6c4e

• respond to feedback

  stan-dot

  committed
  2e874c5

  Copy full SHA for 2e874c5

• add repr that includes the config

  stan-dot

  committed
  4660721

  Copy full SHA for 4660721

• lint

  stan-dot

  committed
  1d95a9a

  Copy full SHA for 1d95a9a

• remove old panda ref

  stan-dot

  committed
  7c90c0d

  Copy full SHA for 7c90c0d

• fix import

  stan-dot

  committed
  ddd583b

  Copy full SHA for ddd583b

• fix the tests

  stan-dot

  committed
  01b5b7b

  Copy full SHA for 01b5b7b

• pin pyright version due to is_device check failing

  stan-dot

  committed
  29fd6fc

  Copy full SHA for 29fd6fc

• cancel pyright pinning

  stan-dot

  committed
  df1082b

  Copy full SHA for df1082b

• renaming

  stan-dot

  committed
  17a8f5f

  Copy full SHA for 17a8f5f

• partial update to fix the test coverage for the factory

  stan-dot

  committed
  006e97a

  Copy full SHA for 006e97a

• maybe fixed

  stan-dot

  committed
  e02d9d4

  Copy full SHA for e02d9d4

• imports fix

  stan-dot

  committed
  8572b49

  Copy full SHA for 8572b49

• fix imports

  stan-dot

  committed
  ef604dd

  Copy full SHA for ef604dd

• forgot one

  stan-dot

  committed
  3e1643a

  Copy full SHA for 3e1643a

• added test to increase coverage, still broken a bit

  stan-dot

  committed
  12980b5

  Copy full SHA for 12980b5

• towards a stable problem definitio a stable problme definition

  stan-dot

  committed
  f5f6949

  Copy full SHA for f5f6949

• fix the test instance

  stan-dot

  committed
  048c7c7

  Copy full SHA for 048c7c7

• finally fixed tests

  stan-dot

  committed
  8f6c8ca

  Copy full SHA for 8f6c8ca

• lint

  stan-dot

  committed
  3888726

  Copy full SHA for 3888726

• fix tests

  stan-dot

  committed
  305f1d9

  Copy full SHA for 305f1d9

• exit some tests early

  stan-dot

  committed
  3bb1815

  Copy full SHA for 3bb1815

• remove pytest skip

  stan-dot

  committed
  8d1873f

  Copy full SHA for 8d1873f

• hardcode the i22 slit refs

  stan-dot

  committed
  48ad3d1

  Copy full SHA for 48ad3d1

• i22 remove device_instantiation

  stan-dot

  committed
  a47b2d7

  Copy full SHA for a47b2d7

• respond to feedback

  stan-dot

  committed
  4a96f79

  Copy full SHA for 4a96f79

• more tests to raise coverage

  stan-dot

  committed
  d3020c7

  Copy full SHA for d3020c7

• respond to comment on the connect logic in controller call

  stan-dot

  committed
  31beeef

  Copy full SHA for 31beeef

• deprecation warning added

  stan-dot

  committed
  f704cb2

  Copy full SHA for f704cb2

• remove the v1 ophyd relevant piece of logic - fake_with_ophyd_sim

  stan-dot

  committed
  e2887aa

  Copy full SHA for e2887aa

• halfway through

  stan-dot

  committed
  1af9cd7

  Copy full SHA for 1af9cd7

• identified the issue

  stan-dot

  committed
  c75e693

  Copy full SHA for c75e693

• name param issues

  stan-dot

  committed
  adef60b

  Copy full SHA for adef60b

• add new appropriate mocks

  stan-dot

  committed
  396cfbe

  Copy full SHA for 396cfbe

• merged the two dictionaries to preserve the connected functionality

  stan-dot

  committed
  a986877

  Copy full SHA for a986877

• quickfix

  stan-dot

  committed
  2aca80f

  Copy full SHA for 2aca80f

• try reverting the factory name change

  stan-dot

  committed
  b58cb7a

  Copy full SHA for b58cb7a

• change the expected beamline in test_cli

  stan-dot

  committed
  f4aa047

  Copy full SHA for f4aa047

• increase coverage

  stan-dot

  committed
  2955088

  Copy full SHA for 2955088

• fix lint newlien

  stan-dot

  committed
  580b7c9

  Copy full SHA for 580b7c9

• add one more line

  stan-dot

  committed
  06954f1

  Copy full SHA for 06954f1

• linting

  

  DiamondJoseph

  authored and

  stan-dot

  committed
  057080a

  Copy full SHA for 057080a

• remove unused imports

  stan-dot

  committed
  0433521

  Copy full SHA for 0433521

• restore the movable readable interface

  stan-dot

  committed
  259e68f

  Copy full SHA for 259e68f

• respond to feedback

  stan-dot

  committed
  9321f4c

  Copy full SHA for 9321f4c

• apply suggestions to the i22.py

  stan-dot

  committed
  7553a97

  Copy full SHA for 7553a97

• respond to feedback

  stan-dot

  committed
  c28c7c4

  Copy full SHA for c28c7c4

• add hasattr to the module parsing

  stan-dot

  committed
  c2e8553

  Copy full SHA for c2e8553