-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
689 convert to ophyd async ipin #712
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #712 +/- ##
=======================================
Coverage 94.50% 94.50%
=======================================
Files 110 110
Lines 4384 4387 +3
=======================================
+ Hits 4143 4146 +3
Misses 241 241 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you. One comment on the naming, otherwise good.
392a9fa
to
bdcd23e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@stan-dot please squash and merge and rewrite the squashed commits to something sensible |
Fixes #689
Instructions to reviewer on how to test:
Checks for reviewer
dodal connect ${BEAMLINE}