Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

689 convert to ophyd async ipin #712

Merged
merged 4 commits into from
Aug 7, 2024
Merged

Conversation

stan-dot
Copy link
Contributor

Fixes #689

Instructions to reviewer on how to test:

  1. run dodal connect i04
  2. make sure the device is connected
  3. make sure the device is readable in a run (plans in mx_bluesky)

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

@stan-dot stan-dot added enhancement New feature or request python Pull requests that update Python code labels Jul 29, 2024
@stan-dot stan-dot requested review from DominicOram and d-perl July 29, 2024 15:28
@stan-dot stan-dot self-assigned this Jul 29, 2024
@stan-dot stan-dot linked an issue Jul 29, 2024 that may be closed by this pull request
Copy link

codecov bot commented Jul 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.50%. Comparing base (be0f6ba) to head (5e77b65).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #712   +/-   ##
=======================================
  Coverage   94.50%   94.50%           
=======================================
  Files         110      110           
  Lines        4384     4387    +3     
=======================================
+ Hits         4143     4146    +3     
  Misses        241      241           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you. One comment on the naming, otherwise good.

src/dodal/devices/ipin.py Outdated Show resolved Hide resolved
src/dodal/devices/ipin.py Outdated Show resolved Hide resolved
@stan-dot stan-dot marked this pull request as ready for review July 30, 2024 11:34
@stan-dot stan-dot force-pushed the 689-convert-to-ophyd-async-ipin branch from 392a9fa to bdcd23e Compare August 1, 2024 12:13
Copy link
Contributor

@DiamondJoseph DiamondJoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DiamondJoseph DiamondJoseph dismissed DominicOram’s stale review August 6, 2024 14:56

All issues addressed

@DiamondJoseph
Copy link
Contributor

@stan-dot please squash and merge and rewrite the squashed commits to something sensible

@stan-dot stan-dot merged commit 505af55 into main Aug 7, 2024
18 checks passed
@stan-dot stan-dot deleted the 689-convert-to-ophyd-async-ipin branch August 7, 2024 08:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert to ophyd-async: ipin
3 participants