Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Modify the deploy script to run on the control machine so that the correct versions of dependencies are installed #1103

Closed
d-perl opened this issue Jan 26, 2024 · 4 comments · Fixed by #1369
Assignees
Labels
needed_for_release Issues that must be complete before the next release

Comments

@d-perl
Copy link
Contributor

d-perl commented Jan 26, 2024

RHEL 7 is limited to GLIBC 2.17, which limits pyzmq to <25 for the default wheel. However, there is an pyzmq-26.0.2-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl build which is still compatible, and will be installed if the pip install is run on the control machine instead of a RHEL8(+) machine

Acceptance criteria:

  • deploy script builds the venv ssh'd to the control machine
  • dependency pin for pyzmq is removed
@DominicOram DominicOram moved this to Backlog in Hyperion Jan 26, 2024
@d-perl d-perl changed the title RHEL 7 is limited to GLIBC 2.17, which limits pyzmq to <25 Modify the deploy script to run on the control machine so that the correct versions of dependencies are installed Apr 22, 2024
@DominicOram
Copy link
Collaborator

Maybe this is a sign we should containerize?

@DominicOram DominicOram moved this from Backlog to Candidates for Next Sprint in Hyperion May 1, 2024
@DominicOram
Copy link
Collaborator

Lets do the control machine fix for now and think harder about long term solutions

@DominicOram DominicOram added the needed_for_release Issues that must be complete before the next release label May 7, 2024
@DominicOram DominicOram moved this from Candidates for Next Sprint to Todo This Sprint in Hyperion May 7, 2024
@DominicOram
Copy link
Collaborator

  • @dperl-dls spent some time trying to force pip to get the correct wheel
  • This may mean that the deployment script asks you for ssh credentials, that's fine
  • Want to confirm it works for a couple of people
  • Either do in shutdown, on a Tuesday or ask Neil for testing time
  • We think small

@olliesilvester
Copy link
Contributor

See DiamondLightSource/mx-bluesky#250 for the longer term solution

@olliesilvester olliesilvester self-assigned this May 9, 2024
@DominicOram DominicOram moved this from Todo This Sprint to In Progress in Hyperion May 9, 2024
@DominicOram DominicOram moved this from In Progress to Review in Hyperion May 9, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in Hyperion May 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needed_for_release Issues that must be complete before the next release
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants