Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Make deploy script create venv while SSH'd into control machine #1369

Merged
merged 7 commits into from
May 14, 2024

Conversation

olliesilvester
Copy link
Contributor

@olliesilvester olliesilvester commented May 9, 2024

Fixes #1103

Now uses subprocess to SSH, so that it only asks for the password if it needs it

To test:

  1. Confirm deploy script in dev mode still works as expected, using python deploy_hyperion.py "dev" (NOTE: this won't actually work until we make a release with this change merged in, since the script will search the latest release for the file created in this PR)
  2. We don't have unit tests for the deploy script, so test live on beamline for next deployment

@olliesilvester olliesilvester marked this pull request as ready for review May 9, 2024 14:33
Copy link
Contributor

@d-perl d-perl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script changes look good, couple comments

setup.cfg Outdated Show resolved Hide resolved
utility_scripts/deploy/deploy_hyperion.py Outdated Show resolved Hide resolved
@olliesilvester olliesilvester requested a review from d-perl May 13, 2024 12:47
Copy link
Contributor

@d-perl d-perl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks!

@olliesilvester olliesilvester merged commit a489997 into main May 14, 2024
5 of 6 checks passed
@olliesilvester olliesilvester deleted the 1103_deploy_script_sshs_to_control_machine branch May 14, 2024 11:09
olliesilvester added a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
…Source/1103_deploy_script_sshs_to_control_machine

Make deploy script create venv while SSH'd into control machine
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants