Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Get rid of detector type string #1307

Closed
d-perl opened this issue Apr 11, 2024 · 1 comment · Fixed by #1420
Closed

Get rid of detector type string #1307

d-perl opened this issue Apr 11, 2024 · 1 comment · Fixed by #1420
Assignees
@rtuck99

Comments

@d-perl
Copy link
Contributor

d-perl commented Apr 11, 2024

following #1284 and #1277 we can just use the DetectorSizeConstants and forget about the string field in the params.
@DominicOram DominicOram moved this to Backlog in Hyperion Apr 11, 2024
@DominicOram DominicOram mentioned this issue May 13, 2024
Merged
@DominicOram DominicOram moved this from Backlog to Candidates for Next Sprint in Hyperion May 16, 2024
@rtuck99 rtuck99 self-assigned this May 28, 2024
@DominicOram DominicOram moved this from Candidates for Next Sprint to In Progress in Hyperion May 28, 2024
@DominicOram
Copy link
Collaborator

  • This can change based on ROI mode
  • The validator needs to look at whether we're in the ROI mode or not then use the correct type for it

@rtuck99 rtuck99 mentioned this issue May 29, 2024
Merged
@DominicOram DominicOram moved this from In Progress to Review in Hyperion May 29, 2024
@DominicOram DominicOram moved this from Review to In Progress in Hyperion May 30, 2024
rtuck99 added a commit to DiamondLightSource/dodal that referenced this issue May 30, 2024
@rtuck99
(DiamondLightSource/hyperion#1307) change DetectorParams detector_siz…
e0d9c48 
…e_constants validator to allow the declared type
rtuck99 added a commit that referenced this issue May 30, 2024
@rtuck99
(#1307) change detector_size_constants to be the DetectorSizeParams n…
a362231 
…ot the string
@rtuck99 rtuck99 mentioned this issue May 30, 2024
Merged
4 tasks
@DominicOram DominicOram moved this from In Progress to Review in Hyperion May 30, 2024
rtuck99 added a commit to DiamondLightSource/dodal that referenced this issue Jun 12, 2024
@rtuck99
(DiamondLightSource/hyperion#1307) change DetectorParams detector_siz…
564f970 
…e_constants validator to allow the declared type
rtuck99 added a commit that referenced this issue Jun 12, 2024
@rtuck99
(#1307) change detector_size_constants to be the DetectorSizeParams n…
a83d7f9 
…ot the string
rtuck99 added a commit to DiamondLightSource/dodal that referenced this issue Jun 12, 2024
@rtuck99
(DiamondLightSource/hyperion#1307) change DetectorParams detector_siz…
b63fb1b 
…e_constants validator to allow the declared type (#588)
rtuck99 added a commit that referenced this issue Jun 12, 2024
@rtuck99
1307 remove detector parameter from hyperion request parameters (#1420)
ed7d483 
* (#1307) Remove detector string from params

* (#1307) change detector_size_constants to be the DetectorSizeParams not the string
@github-project-automation github-project-automation bot moved this from Review to Done in Hyperion Jun 12, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@rtuck99
1307 remove detector parameter from hyperion request parameters (Diam…
168f299 
…ondLightSource/hyperion#1420)

* (DiamondLightSource/hyperion#1307) Remove detector string from params

* (DiamondLightSource/hyperion#1307) change detector_size_constants to be the DetectorSizeParams not the string
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rtuck99 rtuck99

Labels
None yet
Projects
Hyperion
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1307 remove detector parameter from hyperion request parameters DiamondLightSource/hyperion
3 participants
@rtuck99 @DominicOram @d-perl