Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

ispyb omega_start value should be read from hardware instead of supplied by params #1327

Closed
rtuck99 opened this issue Apr 23, 2024 · 1 comment · Fixed by #1445
Closed

ispyb omega_start value should be read from hardware instead of supplied by params #1327

rtuck99 opened this issue Apr 23, 2024 · 1 comment · Fixed by #1445
Assignees
@rtuck99

Comments

@rtuck99
Copy link
Contributor

rtuck99 commented Apr 23, 2024

from PR review comment by @DominicOram in #1279
"Should: We should be able to read the omega from the smargon when we do the pin tip detection, can we make an issue for that?"
@DominicOram DominicOram moved this to Backlog in Hyperion Apr 23, 2024
@rtuck99 rtuck99 mentioned this issue Apr 23, 2024
Merged
@DominicOram DominicOram moved this from Backlog to Candidates for Next Sprint in Hyperion Jun 4, 2024
@DominicOram
Copy link
Collaborator

Remember that directionality on smargon vs what we want to put in ispyb is flipped

@DominicOram DominicOram moved this from Candidates for Next Sprint to Todo This Sprint in Hyperion Jun 6, 2024
@rtuck99 rtuck99 self-assigned this Jun 13, 2024
@DominicOram DominicOram moved this from Todo This Sprint to In Progress in Hyperion Jun 13, 2024
rtuck99 added a commit that referenced this issue Jun 14, 2024
@rtuck99
(#1327) ispyb omega_start, axis_start now read from hardware for grid…
9ad74d3 
…scans
@rtuck99 rtuck99 mentioned this issue Jun 14, 2024
Merged
@rtuck99 rtuck99 moved this from In Progress to Review in Hyperion Jun 14, 2024
@DominicOram DominicOram moved this from Review to In Progress in Hyperion Jun 18, 2024
rtuck99 added a commit that referenced this issue Jun 19, 2024
@rtuck99
(#1327) Response to PR comments
6ab0d45
rtuck99 added a commit that referenced this issue Jun 20, 2024
@rtuck99
(#1327) ispyb omega_start, axis_start now read from hardware for grid…
15313f8 
…scans
rtuck99 added a commit that referenced this issue Jun 20, 2024
@rtuck99
(#1327) Response to PR comments
33cc2ed
rtuck99 added a commit that referenced this issue Jun 20, 2024
@rtuck99
(#1327) refactor ispyb_callback classes as per PR discussion
5ece6bd
rtuck99 added a commit that referenced this issue Jun 21, 2024
@rtuck99
(#1327) ispyb omega_start, axis_start now read from hardware for grid…
73c4623 
…scans (#1445)

* (#1327) ispyb omega_start, axis_start now read from hardware for gridscans

* (#1327) Response to PR comments

* (#1327) refactor ispyb_callback classes as per PR discussion
@github-project-automation github-project-automation bot moved this from In Progress to Done in Hyperion Jun 21, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
@rtuck99
(DiamondLightSource/hyperion#1327) ispyb omega_start, axis_start now …
2e313e4 
…read from hardware for gridscans (DiamondLightSource/hyperion#1445)

* (DiamondLightSource/hyperion#1327) ispyb omega_start, axis_start now read from hardware for gridscans

* (DiamondLightSource/hyperion#1327) Response to PR comments

* (DiamondLightSource/hyperion#1327) refactor ispyb_callback classes as per PR discussion
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rtuck99 rtuck99

Labels
None yet
Projects
Hyperion
Archived in project
Milestone
No milestone
2 participants
@rtuck99 @DominicOram