Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Wait on aperture_scatterguard move and read during collection #1466

Closed
DominicOram opened this issue Jun 27, 2024 · 0 comments · Fixed by #1472
Closed

Wait on aperture_scatterguard move and read during collection #1466

DominicOram opened this issue Jun 27, 2024 · 0 comments · Fixed by #1472
Assignees
Labels
needed_for_release Issues that must be complete before the next release

Comments

@DominicOram
Copy link
Collaborator

Following #1465 we're not waiting for the aperture_scatterguard to settle before trying to read it for ispyb. Given this is quite a slow move it would be beneficial to wait on it as late as possible. As such, the proposed solution is:

  • Change the default group on the aperture move to ready_for_data_collection. This will make sure we wait on the movement as late as possible for the collection
  • Put the reading of the aperture into read_hardware_for_ispyb_during_collection rather than read_hardware_for_ispyb_pre_collection so that we can wait for it later
  • Move read_hardware_for_ispyb_during_collection to actually happen during collection

We probably want to do a similar thing for the grids and the rotation

Acceptance Criteria

  • We make sure to wait on the aperture move before putting in ispyb and before collection
  • This happens as late as possible in the plan
@DominicOram DominicOram moved this to Backlog in Hyperion Jun 27, 2024
@DominicOram DominicOram moved this from Backlog to Candidates for Next Sprint in Hyperion Jun 27, 2024
@DominicOram DominicOram added the needed_for_release Issues that must be complete before the next release label Jun 27, 2024
@d-perl d-perl self-assigned this Jul 3, 2024
@DominicOram DominicOram moved this from Candidates for Next Sprint to In Progress in Hyperion Jul 3, 2024
@DominicOram DominicOram moved this from In Progress to Review in Hyperion Jul 3, 2024
@DominicOram DominicOram moved this from In Progress to Review in Hyperion Jul 3, 2024
DominicOram added a commit that referenced this issue Jul 10, 2024
* (#1466) Wait for aperture move before DC and read it during DC

* Use constant for dc group

* Fix connecting smargon

---------

Co-authored-by: Dominic Oram <[email protected]>
@github-project-automation github-project-automation bot moved this from Review to Done in Hyperion Jul 10, 2024
@DominicOram DominicOram removed this from Hyperion Jul 29, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this issue Aug 23, 2024
…nd read it during DC (DiamondLightSource/hyperion#1472)

* (DiamondLightSource/hyperion#1466) Wait for aperture move before DC and read it during DC

* Use constant for dc group

* Fix connecting smargon

---------

Co-authored-by: Dominic Oram <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needed_for_release Issues that must be complete before the next release
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants