Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Use dodal PulseOutput device for the Zebra output panel #1135

Merged
merged 6 commits into from
Feb 14, 2024

Conversation

noemifrisina
Copy link
Contributor

Small device added to the Zebra in dodal, updating hyperion to use it.

Link to dodal PR (if required): #229

To test:

  1. Check correct device used
  2. Check tests still pass

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (10e5573) 93.04% compared to head (39cef2a) 93.04%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1135   +/-   ##
=======================================
  Coverage   93.04%   93.04%           
=======================================
  Files          69       69           
  Lines        3436     3436           
=======================================
  Hits         3197     3197           
  Misses        239      239           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@d-perl d-perl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the fields on the dodal device please be named input, delay, and width rather than the abbreviated versions? otherwise looks good.

@noemifrisina noemifrisina requested a review from d-perl February 13, 2024 16:55
Copy link
Contributor

@d-perl d-perl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@noemifrisina noemifrisina merged commit 4fefc9a into main Feb 14, 2024
6 checks passed
@noemifrisina noemifrisina deleted the dodal_299-use-zebra-pulse-output-device branch February 14, 2024 16:50
d-perl added a commit that referenced this pull request Mar 1, 2024
d-perl added a commit that referenced this pull request Mar 1, 2024
d-perl added a commit that referenced this pull request Mar 1, 2024
d-perl added a commit that referenced this pull request Mar 1, 2024
d-perl added a commit that referenced this pull request Mar 1, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
…Source/dodal_299-use-zebra-pulse-output-device

Use dodal PulseOutput device for the Zebra output panel
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants