Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Improve logging #1137

Merged
merged 17 commits into from
Feb 15, 2024
Merged

Improve logging #1137

merged 17 commits into from
Feb 15, 2024

Conversation

d-perl
Copy link
Contributor

@d-perl d-perl commented Feb 8, 2024

Fixes #910, Fixes #1150

  • Removes the logging-level CLI argument as handlers are now instantiated with default args
  • tidies up logging setup
  • stops us from logging to prod graylog in tests

Link to dodal PR (if required): DiamondLightSource/dodal#320

To test:

  1. Run tests

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (4fefc9a) 93.04% compared to head (e3b7353) 92.96%.
Report is 2 commits behind head on main.

❗ Current head e3b7353 differs from pull request most recent head 990209f. Consider uploading reports for the commit 990209f to get more accurate results

Files Patch % Lines
src/hyperion/parameters/cli.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1137      +/-   ##
==========================================
- Coverage   93.04%   92.96%   -0.08%     
==========================================
  Files          69       69              
  Lines        3436     3413      -23     
==========================================
- Hits         3197     3173      -24     
- Misses        239      240       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@noemifrisina noemifrisina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@d-perl d-perl merged commit 72323ae into main Feb 15, 2024
6 checks passed
@d-perl d-perl deleted the 910_dodal_257_improve_logging_capability branch February 15, 2024 15:24
@olliesilvester olliesilvester mentioned this pull request Feb 29, 2024
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
…Source/910_dodal_257_improve_logging_capability

Improve logging
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests on dev machine logging to prod graylog Retention policy on logs
2 participants