Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

#1132 Remove need for metadata tag for logs #1233

Merged
merged 3 commits into from
Mar 7, 2024
Merged

#1132 Remove need for metadata tag for logs #1233

merged 3 commits into from
Mar 7, 2024

Conversation

d-perl
Copy link
Contributor

@d-perl d-perl commented Mar 7, 2024

To test:

  1. See that test_messages_are_tagged_with_run_uid still passes even without the plan metadata

Copy link
Collaborator

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks cleaner. But whilst we're here:

  • What is create_and_set_new doing on the RunUIDFilter? I don't think it's used.
  • Could: I wonder whether we can combine the DCGIDFilter and RunUIDFilter classes into some kind of AppendMetaDataFilter which takes the name of the parameter to append as on __init__ but then still have separate instances for run_uid and dc_group?

@d-perl d-perl requested a review from DominicOram March 7, 2024 14:29
Copy link
Collaborator

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@d-perl d-perl merged commit ad13d11 into main Mar 7, 2024
6 checks passed
@d-perl d-perl deleted the fix_log_uid branch March 7, 2024 14:39
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants