This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Make common FGS and convert to ophyd async #1294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olliesilvester
changed the title
rtuck99
reviewed
Apr 12, 2024
| @@ -589,8 +590,12 @@ def fake_fgs_composite( | |||
| False | |||
| ) | |||
|
|
|||
There was a problem hiding this comment.
I assume this is to be invoked separately from future tests and this commented out code can be removed?
There was a problem hiding this comment.
Still agree that this commented out code needs to go
olliesilvester
force-pushed
the
dodal_413_make_common_fgs
branch
from
f25fc01 to
a3cb801
Compare
olliesilvester
force-pushed
the
dodal_413_make_common_fgs
branch
from
5b39279 to
89ef0da
Compare
2 tasks
olliesilvester
force-pushed
the
dodal_413_make_common_fgs
branch
from
da6b590 to
60a1298
Compare
rtuck99
approved these changes
May 30, 2024
DominicOram
suggested changes
Jun 3, 2024
| @@ -589,8 +590,12 @@ def fake_fgs_composite( | |||
| False | |||
| ) | |||
|
|
|||
There was a problem hiding this comment.
Still agree that this commented out code needs to go
olliesilvester
added a commit
to olliesilvester/mx-bluesky
that referenced
this pull request
Aug 23, 2024
…on#1294) * Update plans to use common FGS device
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dodal #413
Link to dodal PR (if required): #422
(remember to update
setup.cfgwith the dodal commit tag if you need it for tests to pass!)After this is merged, we should be able to combine the
flyscan_xray_centreandpanda_flyscan_xray_centreplansTo test: