Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Remove redundant ispyb params param #1297

Merged
merged 4 commits into from
Apr 9, 2024
Merged

Remove redundant ispyb params param #1297

merged 4 commits into from
Apr 9, 2024

Conversation

DominicOram
Copy link
Collaborator

@DominicOram DominicOram commented Apr 8, 2024 •
edited
Loading

Fixes #1292

To test:

  1. Confirm all instances of current_energy_ev are removed
  2. Confirm all instances of ispyb_params.transmission_fraction are removed
  3. Confirm all instances of ispyb_params.flux are removed
  4. Confirm tests still pass (other than the known failure in Fix unit test due to dodgy merge #1296)

@DominicOram DominicOram changed the title Remove redundant current_energy_ev param Remove redundant ispyb params param Apr 8, 2024
@DominicOram DominicOram force-pushed the 1292_remove_redundant_params branch from 4e98b70 to 34f63b6 Compare April 8, 2024 19:50
rtuck99
rtuck99 approved these changes Apr 9, 2024
View reviewed changes
Copy link
Contributor

@rtuck99 rtuck99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine, I can't find anywhere you've missed

@rtuck99 rtuck99 merged commit 602c108 into main Apr 9, 2024
5 of 6 checks passed
@rtuck99 rtuck99 deleted the 1292_remove_redundant_params branch April 9, 2024 09:53
@DominicOram DominicOram mentioned this pull request Apr 9, 2024
Merged
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
@DominicOram
(DiamondLightSource/hyperion#1297) Remove transmission from ispyb params
0f7dda6
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
@DominicOram
(DiamondLightSource/hyperion#1297) Remove flux from ispyb_params
a1c6001
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
@rtuck99
Merge pull request DiamondLightSource/hyperion#1297 from DiamondLight…
ec83462 
…Source/1292_remove_redundant_params

Remove redundant ispyb params param
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rtuck99 rtuck99 rtuck99 approved these changes

@d-perl d-perl Awaiting requested review from d-perl

@olliesilvester olliesilvester Awaiting requested review from olliesilvester

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove setting of parameters in ispyb_params
2 participants
@DominicOram @rtuck99