This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Use new params in rotation scan plan #1326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-perl
force-pushed
the
1275_use_new_params_in_rotation
branch
2 times, most recently
from
0638225 to
0c16545
Compare
d-perl
force-pushed
the
1275_use_new_params_in_rotation
branch
from
0c16545 to
bd9b695
Compare
DominicOram
suggested changes
Apr 25, 2024
| @@ -253,62 +248,61 @@ def cleanup_plan(composite: RotationScanComposite, max_vel: float, **kwargs): | |||
|
|
|||
| def rotation_scan( | |||
| composite: RotationScanComposite, | |||
| parameters: Union[RotationScan, RotationInternalParameters, Any], | |||
| parameters: RotationScan | Any, | |||
There was a problem hiding this comment.
Could: Why does this need to accept Any?
There was a problem hiding this comment.
Must: This needs to be a Union, until we have a release with DiamondLightSource/blueapi#432
There was a problem hiding this comment.
It actually doesn't need to accept Any, I guess it used to need it with the old params for some blueAPI reason I didn't understand & I cargo-culted it in.
rtuck99
reviewed
Apr 29, 2024
| "y_start_um": 2.0, | ||
| "z_start_um": 3.0, | ||
| "ispyb_extras": { | ||
| "microns_per_pixel_x": 1.0, |
There was a problem hiding this comment.
Need to remove microns_per_pixel and upper_left once rebased
DominicOram
approved these changes
May 10, 2024
d-perl
force-pushed
the
1275_use_new_params_in_rotation
branch
from
cb6a0b4 to
ab24a61
Compare
olliesilvester
pushed a commit
to olliesilvester/mx-bluesky
that referenced
this pull request
Aug 23, 2024
…Source/1275_use_new_params_in_rotation Use new params in rotation scan plan
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes towards #1275
Uses the new param model throughout rotation scan plan
adds a little move chi/phi setup plan because this was expected behaviour our tests missed due to the default position being 0
To test: