Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

(#1275) convert pin and grid detect plans to new params #1330

Merged
merged 2 commits into from
Apr 24, 2024

Conversation

d-perl
Copy link
Contributor

@d-perl d-perl commented Apr 24, 2024

part of #1275

Uses the new params for pin/grid detect and xray centre (leaves xray centre alone still)

To test:

  1. Run tests

@d-perl d-perl force-pushed the 1275_use_new_params_in_grid_then_xray branch from 7dc83cd to 8591fce Compare April 24, 2024 09:28
Copy link
Contributor

@rtuck99 rtuck99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's all there now, looks like it was just upper_left, I was probably thinking of stuff that wasn't in that last ispyb PR

@d-perl d-perl merged commit ea11e8b into main Apr 24, 2024
6 checks passed
@d-perl d-perl deleted the 1275_use_new_params_in_grid_then_xray branch April 24, 2024 09:45
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
…Source/1275_use_new_params_in_grid_then_xray

(DiamondLightSource/hyperion#1275) convert pin and grid detect plans to new params
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants