This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Take snapshots before robot load #1333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olliesilvester
approved these changes
Apr 26, 2024
| @@ -62,7 +62,12 @@ def activity_gated_event(self, doc: Event) -> Event | None: | |||
| self.action_id is not None | |||
| ), "ISPyB Robot load callback event called unexpectedly" | |||
| barcode = doc["data"]["robot-barcode"] | |||
| self.expeye.update_barcode(self.action_id, barcode) | |||
| oav_snapshot = doc["data"]["oav_snapshot_last_saved_path"] | |||
There was a problem hiding this comment.
How do you know if you need dashes or hyphens in lines like webcam_snapshot = doc["data"]["webcam-last_saved_path"]?
There was a problem hiding this comment.
So when you have a device like:
class MyDevice():
self.signal = ...
my_device = MyDevice()Then you do yield from bps.read(my_device) the RE produces a document with data like:
data: {
"X": "value"
}
Where:
- In
ophyd_is used as a separator so X ismy_device_signal ophyd_asyncinstead uses-so X ismy_device-signal
If you tried to look in the dict for the wrong one you would fail with a KeyError. This is a frustrating breaking change between the two but it does make sense because _ is a valid (and commonly used) part of a variable name it's impossible to know which was the device and signal in my_device_signal by just looking at the string. By using - instead you can work that out.
olliesilvester
pushed a commit
to olliesilvester/mx-bluesky
that referenced
this pull request
Aug 23, 2024
…Source/1282_robot_load_snapshots Take snapshots before robot load
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1282
Dodal PR: DiamondLightSource/dodal#468
To test: