Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Add panda support for writing positions #1337

Conversation

rtuck99
Copy link
Contributor

@rtuck99 rtuck99 commented Apr 29, 2024

  • Change references from PandA to HDFPanda
  • Apply directory path from params

Fixes DiamondLightSource/dodal#466

Link to dodal PR (if required): DiamondLightSource/dodal#477
(remember to update setup.cfg with the dodal commit tag if you need it for tests to pass!)

To test:

  1. Tests pass
  2. Hyperion now saves HDF files in the location specified by the storage_directory request parameter

…in panda

* Change references from PandA to HDFPanda
* Apply directory path from params
@DominicOram DominicOram changed the title (DiamondLightSource/dodal#466) panda support for saving HDF files Add panda support for writing positions Apr 29, 2024
Copy link
Collaborator

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@DominicOram DominicOram merged commit 669f3ad into main Apr 29, 2024
18 checks passed
@DominicOram DominicOram deleted the dodal_466_pandas_in_ophyd_async_0.3_require_directory_provider branch April 29, 2024 09:30
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
…Source/dodal_466_pandas_in_ophyd_async_0.3_require_directory_provider

Add panda support for writing positions
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PandAs in ophyd-async 0.3 require DirectoryProvider information
2 participants