Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Convert UDCDirectoryProvider to standard pattern #1352

Merged
merged 6 commits into from
May 9, 2024
Merged

Conversation

DiamondJoseph
Copy link
Contributor

@DiamondJoseph DiamondJoseph commented May 7, 2024

Fixes #1355

Link to dodal PR (if required): #505
(remember to update setup.cfg with the dodal commit tag if you need it for tests to pass!)

This ensures that the DirectoryProvider is a singleton that will reliably be shared between all devices if e.g. copying a detector from an existing beamline. It also exposes it to the pre-processor that is being used for configuring devices per-Run.

To test:

  1. Check that PandA would write into correct directory for parameters if it wrote to a directory

Copy link
Contributor

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, although if you agree with my suggested dodal changes then this will need to be updated before merging

@olliesilvester olliesilvester merged commit bfd274b into main May 9, 2024
6 checks passed
@olliesilvester olliesilvester deleted the dirProvider branch May 9, 2024 12:31
olliesilvester added a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
…Source/dirProvider

 Convert UDCDirectoryProvider to standard pattern
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use standard pattern for UDCDirectoryProvider
2 participants