This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
(#1354) update Hyperion to use the new ApertureScatterguard #1356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominicOram
suggested changes
May 7, 2024
tests/conftest.py
Outdated
Comment on lines
192
to
193
| motor.user_setpoint._backend._set_value(val) # type: ignore | ||
| motor.user_readback._backend._set_value(val) # type: ignore |
There was a problem hiding this comment.
Should: I think it's cleaner to do:
Suggested change
| motor.user_setpoint._backend._set_value(val) # type: ignore | |
| motor.user_readback._backend._set_value(val) # type: ignore | |
| set_sim_value(motor.user_setpoint, val) | |
| set_sim_value(motor.user_readback, val) |
Similarly elsewhere in this file
tests/conftest.py
Outdated
Comment on lines
493
to
494
| ap_sg.aperture.z.user_setpoint._backend._set_value(2) # type: ignore | ||
| ap_sg.aperture.z.motor_done_move._backend._set_value(1) # type: ignore |
There was a problem hiding this comment.
Should: I think you can just set patch_async_motor(ap_sg.aperture.z, 2), below and then remove these 2 lines
DominicOram
approved these changes
May 7, 2024
Co-authored-by: Dominic Oram <[email protected]>
olliesilvester
pushed a commit
to olliesilvester/mx-bluesky
that referenced
this pull request
Aug 23, 2024
…Source/1354_update_ap_sg (DiamondLightSource/hyperion#1354) update Hyperion to use the new ApertureScatterguard
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1354
Link to dodal PR (if required): DiamondLightSource/dodal#509
To test: