This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
(Dodal #487) Improve logging formatting for documents #1373
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-perl
changed the title
d-perl
force-pushed
the
487_improve_logging_formatting
branch
from
a81fce8 to
05d2dc1
Compare
d-perl
force-pushed
the
487_improve_logging_formatting
branch
from
05d2dc1 to
611a7b1
Compare
DominicOram
suggested changes
May 13, 2024
There was a problem hiding this comment.
Great, thank you! I think you may have missed:
create_parameters_for_grid_detection-
ISPYB_LOGGER.warning( f"Ispyb handler {self} recieved event doc {doc} and " "has no corresponding descriptor record" )
-
ISPYB_LOGGER.warning( f"Failed to finalise ISPyB deposition on stop document: {doc} with exception: {e}" )
DominicOram
approved these changes
May 16, 2024
olliesilvester
pushed a commit
to olliesilvester/mx-bluesky
that referenced
this pull request
Aug 23, 2024
…Source/487_improve_logging_formatting (Dodal DiamondLightSource/hyperion#487) Improve logging formatting for documents
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes DiamondLightSource/dodal#487 Fixes #634
Formats the documents in messages emitted by the event logging callback to indented JSON, generating messages like: https://graylog.diamond.ac.uk/messages/graylog-daq-mx-hyperion_17/741f64c5-0ea2-11ef-a69c-fae0dce5bd43
To test: