This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Nexgen 231 thoroughly test nexgen created files against gda #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mpare nexus file (WIP)
…n of rotation nexus file
rtuck99
commented
May 14, 2024
| @@ -71,6 +75,152 @@ def plan(): | |||
| return plan() | |||
|
|
|||
|
|
|||
| def dectris_device_mapping(meta_filename: str): | |||
There was a problem hiding this comment.
Perhaps when we get more sample files with other detectors we could factor this out and drive this from the test data files
|
I would like to merge this to add on to it but leave the issue open until we're sure about the contents of the exceptions etc |
d-perl
merged commit 9834c18
into
1350_nexus_file_cannot_be_read_by_imginfo
5 of 6 checks passed
d-perl
deleted the
nexgen_231_thoroughly_test_nexgen_created_files_against_gda
branch
olliesilvester
pushed a commit
to olliesilvester/mx-bluesky
that referenced
this pull request
Aug 23, 2024
…Source/nexgen_231_thoroughly_test_nexgen_created_files_against_gda Nexgen 231 thoroughly test nexgen created files against gda
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does part of DiamondLightSource/nexgen#231
Link to dodal PR (if required): N/A
(remember to update
setup.cfgwith the dodal commit tag if you need it for tests to pass!)To test:
Unit tests should pass
The expected/exceptional vaues have NOT been verified; the values have been entered based on what the code currently does, on the expectation that it works.
Also perhaps we should split into two tests, one against GDA old data, and one against nexus standard conformance.
Another Q is, whether this test or something like it ought to be in
nexgenrather than here - I am open to suggestions