This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
(#1102) Remove undulator_gap from ispyb_params #1389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominicOram
deleted the
1102_use_energy_as_read_during_collection_in_ispyb
branch
olliesilvester
pushed a commit
to olliesilvester/mx-bluesky
that referenced
this pull request
Aug 23, 2024
…Source/1102_use_energy_as_read_during_collection_in_ispyb (DiamondLightSource/hyperion#1102) Remove undulator_gap from ispyb_params
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1102
This removes the now redundant undulator_gap from the ispyb params
Link to dodal PR (if required): #N/A
(remember to update
setup.cfgwith the dodal commit tag if you need it for tests to pass!)To test: