Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Fix broken system tests #1413

Merged
merged 4 commits into from
May 30, 2024
Merged

Fix broken system tests #1413

merged 4 commits into from
May 30, 2024

Conversation

rtuck99
Copy link
Contributor

@rtuck99 rtuck99 commented May 24, 2024

Fixes various system tests that were broken during parameters refactoring

Link to dodal PR (if required): #N/A
(remember to update setup.cfg with the dodal commit tag if you need it for tests to pass!)

To test:

  1. Tests pass

@rtuck99 rtuck99 force-pushed the fix_broken_system_tests branch from 2b0f49e to ad39944 Compare May 24, 2024 12:56
@rtuck99 rtuck99 requested a review from d-perl May 24, 2024 12:57
Copy link
Collaborator

@DominicOram DominicOram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These look good to me, can we get them merged into main rather than your WIP branch?

Base automatically changed from 1303_read_position_for_rotation_scans_in_ispyb to main May 30, 2024 14:33
@rtuck99 rtuck99 merged commit a7908a7 into main May 30, 2024
8 of 10 checks passed
@rtuck99 rtuck99 deleted the fix_broken_system_tests branch May 30, 2024 14:34
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
* (DiamondLightSource/hyperion#1303) read position for rotation scans in ispyb, remove position from ispyb_params

* Make pyright happy

* Make ruff happy

* Fix broken system tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants