This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
349 Create OAV snapshot plan #1437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rtuck99
commented
Jun 11, 2024
| composite: OavSnapshotComposite, | ||
| parameters: WithSnapshot, | ||
| oav_parameters: OAVParameters, | ||
| wait: bool = True, |
There was a problem hiding this comment.
This wait parameter is here as requested in original issue, but currently unused since we have to wait for the snapshot trigger completion before firing the event. Am open to suggestions to remove it / alternate structuring to make it useful.
There was a problem hiding this comment.
As it is we can remove this, I agree. If we need to do something more complex async we'll need to do it at device level anyway.
rtuck99
requested review from
d-perl and
DominicOram
and removed request for
d-perl
* Remove xtal_snapshots and xtal_snapshots_omega_end from ispyb_extras
rtuck99
force-pushed
the
349_create_oav_snapshot_plan
branch
from
486d71e to
eed8d74
Compare
d-perl
approved these changes
Jun 13, 2024
| composite: OavSnapshotComposite, | ||
| parameters: WithSnapshot, | ||
| oav_parameters: OAVParameters, | ||
| wait: bool = True, |
There was a problem hiding this comment.
As it is we can remove this, I agree. If we need to do something more complex async we'll need to do it at device level anyway.
olliesilvester
pushed a commit
to olliesilvester/mx-bluesky
that referenced
this pull request
Aug 23, 2024
* (DiamondLightSource/hyperion#349) Basic experiment plan for taking snapshots * Remove xtal_snapshots and xtal_snapshots_omega_end from ispyb_extras * (DiamondLightSource/hyperion#349) Tidy parameter model diagram and commit image * (DiamondLightSource/hyperion#349) tidyups
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part 1 of fix for DiamondLightSource/mx-bluesky#388
This creates an experiment plan for taking oav snapshots and also removes some unused parameters from the
ispyb_extrasparameters.ispyb_extrasis now no longer needed for grid scans. OAV snapshots for rotations are still taken by GDA and snapshot paths supplied in parameters; this new plan is not yet invoked by the rotation plan, that work will be in a subsequent PR.Link to dodal PR (if required): #N/A
(remember to update
setup.cfgwith the dodal commit tag if you need it for tests to pass!)To test: