This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Update DEV_ISPYB_DATABASE_CFG to point to ispyb-restore now that ispyb-dev is defunct #1438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominicOram
suggested changes
Jun 12, 2024
There was a problem hiding this comment.
I don't think this will work as the dev version also contains information for exp-eye that we need. See discussion at https://diamondlightsource.slack.com/archives/CKEPJ8E01/p1718187048335559?thread_ts=1718033249.962799&cid=CKEPJ8E01
|
Karl has now updated the old files to point to the new database, we have some other issues (#1441) but I think they're best fixed in a different PR. Suggest we close this? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the credentials file to use ispyb-restore rather than ispyb-dev so that system tests continue to work
Link to dodal PR (if required): #N/A
(remember to update
setup.cfgwith the dodal commit tag if you need it for tests to pass!)To test: