-
Notifications
You must be signed in to change notification settings - Fork 5
Thaw for a set time straight after robot load #1440
Conversation
@@ -182,6 +184,8 @@ def robot_load(): | |||
|
|||
yield from bps.wait("robot_load") | |||
|
|||
yield from bps.abs_set(composite.thawer.thaw_for_time_s, params.thawing_time) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there some point in this plan where we need to check that the thawer is off before continuing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think so. I will double check with Neil
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact @neil-i03 do we need to wait at some point for the thawing to have stopped or we just fire and forget? It's ok to be thawing whilst collecting potentially?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fire and forget. We can collect while thawing (and may have to).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, could optionally add a test to check the new abs_set
and for the pin_centre_then_xray_centre_params
, but they're simple enough functions I think
You're correct, I was being lazy and hoping people wouldn't pick it up, I will do this now |
Tests are failing due to #1448 |
Hmm... This is failing because DiamondLightSource/dodal#609 (comment) breaks the assumption that we have here that all |
|
…erion#1440) * Thaw for a set time straight after robot load * Added test to confirm thawing is turned on for robot_load
Fixes #1418
Link to dodal PR (if required): DiamondLightSource/dodal#609
To test: