Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Thaw for a set time straight after robot load #1440

Merged
merged 9 commits into from
Jun 26, 2024

Conversation

DominicOram
Copy link
Collaborator

Fixes #1418

Link to dodal PR (if required): DiamondLightSource/dodal#609

To test:

  1. Confirm that this would kick off the thawer after robot load

@@ -182,6 +184,8 @@ def robot_load():

yield from bps.wait("robot_load")

yield from bps.abs_set(composite.thawer.thaw_for_time_s, params.thawing_time)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some point in this plan where we need to check that the thawer is off before continuing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so. I will double check with Neil

Copy link
Collaborator Author

@DominicOram DominicOram Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In fact @neil-i03 do we need to wait at some point for the thawing to have stopped or we just fire and forget? It's ok to be thawing whilst collecting potentially?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fire and forget. We can collect while thawing (and may have to).

Copy link
Contributor

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could optionally add a test to check the new abs_set and for the pin_centre_then_xray_centre_params, but they're simple enough functions I think

@DominicOram
Copy link
Collaborator Author

Looks good, could optionally add a test to check the new abs_set and for the pin_centre_then_xray_centre_params

You're correct, I was being lazy and hoping people wouldn't pick it up, I will do this now

@DominicOram
Copy link
Collaborator Author

Tests are failing due to #1448

@DominicOram
Copy link
Collaborator Author

Hmm... This is failing because DiamondLightSource/dodal#609 (comment) breaks the assumption that we have here that all Movable things have a name

@olliesilvester
Copy link
Contributor

olliesilvester commented Jun 25, 2024

Hmm... This is failing because DiamondLightSource/dodal#609 (comment) breaks the assumption that we have here that all Movable things have a name

See DiamondLightSource/dodal#609 (comment)

@DominicOram DominicOram merged commit 9271fa7 into main Jun 26, 2024
4 checks passed
@DominicOram DominicOram deleted the 1418_thaw_after_robot_load branch June 26, 2024 14:49
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
…erion#1440)

* Thaw for a set time straight after robot load

* Added test to confirm thawing is turned on for robot_load
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turn thawing on after robot load
3 participants