Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

(DiamondLightSource/dodal#229) Fix unit tests after converting xbpm_feedback to ophyd_async #1449

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

rtuck99
Copy link
Contributor

@rtuck99 rtuck99 commented Jun 17, 2024

Fixes DiamondLightSource/dodal#229

Link to dodal PR (if required): DiamondLightSource/dodal#626
(remember to update setup.cfg with the dodal commit tag if you need it for tests to pass!)

To test:

  1. Tests still pass

@rtuck99 rtuck99 marked this pull request as ready for review June 17, 2024 13:22
@d-perl d-perl self-assigned this Jun 18, 2024
Copy link
Contributor

@d-perl d-perl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thanks

@rtuck99 rtuck99 merged commit adfcf5b into main Jun 19, 2024
3 of 4 checks passed
@rtuck99 rtuck99 deleted the dodal_229_convert_xbpm_feedback_to_ophyd_async branch June 19, 2024 10:02
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
…sts after converting xbpm_feedback to ophyd_async (DiamondLightSource/hyperion#1449)

* (DiamondLightSource/dodalDiamondLightSource/hyperion#229) Fix unit tests after converting xbpm_feedback to ophyd_async

* bump dodal commit hash
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ophyd-async: Convert the xbpm_feedback device to ophyd-async
2 participants