This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Cache lower gonio positions before robot load and restore them afterwards #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-perl
approved these changes
Jul 18, 2024
| ) | ||
|
|
||
| if demand_energy_ev: | ||
| yield from set_energy_plan( |
There was a problem hiding this comment.
bit tangential, but does the set energy plan always have to block during robot load or could we wait on it later?
There was a problem hiding this comment.
No, we want https://github.com/DiamondLightSource/hyperion/issues/1495 really but needs the RE changes
|
|
||
| yield from bps.wait("robot_load") | ||
| # The lower gonio must be in the correct position for the robot load and we | ||
| # want to put it back afterwards. Note we don't wait as we assume the lower |
There was a problem hiding this comment.
would be good to add explanation of why this is safe here
| yield from bps.wait("robot_load") | ||
|
|
||
|
|
||
| def raise_exception_if_moved_out_of_cryojet(exception): |
olliesilvester
pushed a commit
to olliesilvester/mx-bluesky
that referenced
this pull request
Aug 23, 2024
…ards (DiamondLightSource/hyperion#1467) * First draft of caching lower gonios before robot load * Add test for returning lower_gonio to correct position * Specify argument for readability
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1439
Link to dodal PR (if required): DiamondLightSource/dodal#653
To test: