Skip to content
This repository has been archived by the owner on Sep 2, 2024. It is now read-only.

Combine nexus and ispyb hardware readings and improve naming #1484

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Combine nexus and ispyb hardware readings and improve naming #1484

merged 1 commit into from
Jul 16, 2024

Conversation

d-perl
Copy link
Contributor

@d-perl d-perl commented Jul 15, 2024 •
edited
Loading

Fixes #1482

  • Combines "read hardware for nexus" into the reading during the plan
  • Removes "ispyb" from plan stub names, to make them just "read pre/during collection"

To test:

  1. Run tests

@d-perl d-perl requested review from DominicOram and rtuck99 July 15, 2024 13:53
@d-perl d-perl force-pushed the 1482_nexus_event_ordering branch from f5f2b16 to eac9bb6 Compare July 15, 2024 13:55
@DominicOram DominicOram mentioned this pull request Jul 16, 2024
Closed
rtuck99
rtuck99 approved these changes Jul 16, 2024
View reviewed changes
Copy link
Contributor

@rtuck99 rtuck99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, all looks good

@d-perl d-perl merged commit b7f06e1 into main Jul 16, 2024
6 checks passed
@d-perl d-perl deleted the 1482_nexus_event_ordering branch July 16, 2024 09:50
olliesilvester pushed a commit to olliesilvester/mx-bluesky that referenced this pull request Aug 23, 2024
@d-perl
Combine 'read for nexus' into 'read during plan' (DiamondLightSource/…
a54e876 
…hyperion#1484)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rtuck99 rtuck99 rtuck99 approved these changes

@DominicOram DominicOram Awaiting requested review from DominicOram

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nexus callback: issue with event ordering
2 participants
@d-perl @rtuck99