This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Wrap async behaviour of updating directory_provider #1503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominicOram
approved these changes
Jul 30, 2024
olliesilvester
pushed a commit
to olliesilvester/mx-bluesky
that referenced
this pull request
Aug 23, 2024
…ce/hyperion#1503) * Wrap async behaviour of updating directory_provider * Pin dodal * Await directory update * Call set_and_create_panda_directory as a plan now --------- Co-authored-by: Dominic Oram <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the directory provider update method being made asynchronous for dodal type checking
Link to dodal PR (if required): #719, #718
(remember to update
setup.cfgwith the dodal commit tag if you need it for tests to pass!)To test: